Bug 239178 - devel/erlang-cl: update to 1.2.4 and fix
Summary: devel/erlang-cl: update to 1.2.4 and fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Christoph Moench-Tegeder
URL: https://github.com/tonyrog/cl/releases
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2019-07-12 22:34 UTC by Christoph Moench-Tegeder
Modified: 2019-07-28 22:39 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (amdmi3)


Attachments
update erlang-cl to 1.2.4 and make usable. (3.09 KB, patch)
2019-07-12 22:34 UTC, Christoph Moench-Tegeder
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Moench-Tegeder freebsd_committer 2019-07-12 22:34:56 UTC
Created attachment 205736 [details]
update erlang-cl to 1.2.4 and make usable.

As I'm working myself through some erlang stuff... here's one more:

Attached patch updates devel/erlang-cl to 1.2.4.

While here, patch erlang-cl's build system to actually build the opencl NIF (Native Implemented Function) - previously, the build system didn't know about FreeBSD and failed when building cl_nif.so, but the error went unnoticed.
In fact, my build logs show:

o ../priv/cl_nif.so cl_nif.o cl_hash.o  -fstack-protector-strong 
gmake[2]: o: Command not found
gmake[2]: [Makefile:174: ../priv/cl_nif.so] Error 127 (ignored)
gmake[2]: Leaving directory '/wrkdirs/usr/ports/devel/erlang-cl/work/cl-cl-1.2.3/c_src'
gmake[1]: Leaving directory '/wrkdirs/usr/ports/devel/erlang-cl/work/cl-cl-1.2.3/c_src'

Teach cl's makefiles about FreeBSD, and now we have to depend on devel/ocl-icd (to get libOpenCL). I can't fully test this, as my nvidia card is not that opencl-supported (only under linux emulation?). But without cl_nif.so and libOpenCl erlang-cl wouldn't stand a change at accessing any opencl card.
Comment 1 commit-hook freebsd_committer 2019-07-28 22:33:12 UTC
A commit references this bug:

Author: cmt
Date: Sun Jul 28 22:32:10 UTC 2019
New revision: 507541
URL: https://svnweb.freebsd.org/changeset/ports/507541

Log:
  devel/erlang-cl: update to 1.2.4

  While here, patch this port's build scripts to actually build the
  opencl NIF (Native Implemented Function) - the build system didn't know
  about FreeBSD and failed when building cl_nif.so, but the error went
  unnoticed. Without this object, erlang-cl cannot load any CL function
  (in our case, we want to use libOpenCL), which rather defeats the
  purpose of this port.

  Once we build and install cl_nif.so, we have to depend on devel/ocl-icd
  to pull in libOpenCL.

  PR:		239178
  Approved by:	maintainer-timeout (erlang@)

Changes:
  head/devel/erlang-cl/Makefile
  head/devel/erlang-cl/distinfo
  head/devel/erlang-cl/files/
  head/devel/erlang-cl/files/patch-c__src_Makefile
  head/devel/erlang-cl/pkg-plist
Comment 2 Christoph Moench-Tegeder freebsd_committer 2019-07-28 22:39:43 UTC
committed as ports r507541