Bug 239212 - lang/guile2: Add USES=compiler:c11
Summary: lang/guile2: Add USES=compiler:c11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Muhammad Moinur Rahman
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2019-07-15 01:37 UTC by Justin Hibbits
Modified: 2019-07-25 22:50 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback? (bofh)
koobs: merge-quarterly?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Hibbits freebsd_committer 2019-07-15 01:37:16 UTC
lang/guile2 (testing 2.2.5) tests -std=gnu11 as part of configure, but it's not obvious in the configure messages, only the configure log.

With a non-gnu11-compatible compiler (such as gcc 4.2.1 in base), configure errors out being unable to find libltdl, which is installed as a port LIBDEPENDS.  Checking the config.log shows the real error ("unknown argument -std=gnu11").
Comment 1 Muhammad Moinur Rahman freebsd_committer 2019-07-20 12:25:10 UTC
USES= charsetfix ${USES_${ARCH}} gmake iconv libtool makeinfo ncurses pathfix\
      pkgconfig readline tar:lz
USES_powerpc64= compiler:c11

compiler:c11 is already included as ${USES_${ARCH}}
Comment 2 Justin Hibbits freebsd_committer 2019-07-20 18:12:47 UTC
There are more archs than powerpc64 that need it (powerpc, powerpcspe, and anything else).  Since c11 is required for guile2, it should just be part of the USES line itself.  Otherwise it's whack-a-mole on each arch.
Comment 3 commit-hook freebsd_committer 2019-07-25 17:27:12 UTC
A commit references this bug:

Author: bofh
Date: Thu Jul 25 17:26:40 UTC 2019
New revision: 507325
URL: https://svnweb.freebsd.org/changeset/ports/507325

Log:
  lang/guile2: Update version 2.2.5=>2.2.6

  - Add ATCH wide compiler:c11 [1]

  PR:		239212 [1]
  Submitted by:	jhibbits [1]

Changes:
  head/lang/guile2/Makefile
  head/lang/guile2/distinfo
  head/lang/guile2/pkg-plist