Bug 239265 - libcxxrt std::uncaught_exceptions() rethrow bug
Summary: libcxxrt std::uncaught_exceptions() rethrow bug
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-toolchain mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-07-17 12:17 UTC by Jacques Germishuys
Modified: 2019-07-29 07:11 UTC (History)
2 users (show)

See Also:
dim: mfc-stable12+
dim: mfc-stable11+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jacques Germishuys 2019-07-17 12:17:28 UTC
An uncaught exception count bug which shows up when rethrowing an exception. A fix is available upstream.

References:
https://github.com/catchorg/Catch2/issues/1028

https://github.com/pathscale/libcxxrt/commit/6f4cfa28c42b71cdff570f69ed523ab45d4245be
Comment 1 Conrad Meyer freebsd_committer 2019-07-17 16:14:01 UTC
The bug is also present in CURRENT.
Comment 2 commit-hook freebsd_committer 2019-07-26 16:56:04 UTC
A commit references this bug:

Author: dim
Date: Fri Jul 26 16:55:07 UTC 2019
New revision: 350360
URL: https://svnweb.freebsd.org/changeset/base/350360

Log:
  Merge libcxxrt master f96846efbfd508f66d91fcbbef5dd808947c7f6d.

  Interesting fixes:
  f96846e Fix std::size_t -> size_t to unbreak build against libc++ 6.0.0
  6f4cfa2 Fix the uncaught exception count with rethrowing (PR 239265)
  db54f53 Added C++14-specific operator delete (#47)

  PR:		239265
  MFC after:	3 days

Changes:
_U  head/contrib/libcxxrt/
_U  head/contrib/libcxxrt/abi_namespace.h
_U  head/contrib/libcxxrt/auxhelper.cc
_U  head/contrib/libcxxrt/cxxabi.h
_U  head/contrib/libcxxrt/dwarf_eh.h
_U  head/contrib/libcxxrt/dynamic_cast.cc
  head/contrib/libcxxrt/exception.cc
_U  head/contrib/libcxxrt/guard.cc
_U  head/contrib/libcxxrt/libelftc_dem_gnu3.c
  head/contrib/libcxxrt/memory.cc
_U  head/contrib/libcxxrt/stdexcept.cc
_U  head/contrib/libcxxrt/stdexcept.h
_U  head/contrib/libcxxrt/terminate.cc
_U  head/contrib/libcxxrt/typeinfo.cc
_U  head/contrib/libcxxrt/typeinfo.h
  head/lib/libcxxrt/Makefile
  head/lib/libcxxrt/Version.map
Comment 3 commit-hook freebsd_committer 2019-07-29 06:13:44 UTC
A commit references this bug:

Author: dim
Date: Mon Jul 29 06:13:24 UTC 2019
New revision: 350400
URL: https://svnweb.freebsd.org/changeset/base/350400

Log:
  MFC r350360:

  Merge libcxxrt master f96846efbfd508f66d91fcbbef5dd808947c7f6d.

  Interesting fixes:
  f96846e Fix std::size_t -> size_t to unbreak build against libc++ 6.0.0
  6f4cfa2 Fix the uncaught exception count with rethrowing (PR 239265)
  db54f53 Added C++14-specific operator delete (#47)

  PR:		239265

Changes:
_U  stable/11/
_U  stable/11/contrib/libcxxrt/abi_namespace.h
_U  stable/11/contrib/libcxxrt/auxhelper.cc
_U  stable/11/contrib/libcxxrt/cxxabi.h
_U  stable/11/contrib/libcxxrt/dwarf_eh.h
_U  stable/11/contrib/libcxxrt/dynamic_cast.cc
  stable/11/contrib/libcxxrt/exception.cc
_U  stable/11/contrib/libcxxrt/guard.cc
_U  stable/11/contrib/libcxxrt/libelftc_dem_gnu3.c
  stable/11/contrib/libcxxrt/memory.cc
_U  stable/11/contrib/libcxxrt/stdexcept.cc
_U  stable/11/contrib/libcxxrt/stdexcept.h
_U  stable/11/contrib/libcxxrt/terminate.cc
_U  stable/11/contrib/libcxxrt/typeinfo.cc
_U  stable/11/contrib/libcxxrt/typeinfo.h
  stable/11/lib/libcxxrt/Makefile
  stable/11/lib/libcxxrt/Version.map
_U  stable/12/
_U  stable/12/contrib/libcxxrt/abi_namespace.h
_U  stable/12/contrib/libcxxrt/auxhelper.cc
_U  stable/12/contrib/libcxxrt/cxxabi.h
_U  stable/12/contrib/libcxxrt/dwarf_eh.h
_U  stable/12/contrib/libcxxrt/dynamic_cast.cc
  stable/12/contrib/libcxxrt/exception.cc
_U  stable/12/contrib/libcxxrt/guard.cc
_U  stable/12/contrib/libcxxrt/libelftc_dem_gnu3.c
  stable/12/contrib/libcxxrt/memory.cc
_U  stable/12/contrib/libcxxrt/stdexcept.cc
_U  stable/12/contrib/libcxxrt/stdexcept.h
_U  stable/12/contrib/libcxxrt/terminate.cc
_U  stable/12/contrib/libcxxrt/typeinfo.cc
_U  stable/12/contrib/libcxxrt/typeinfo.h
  stable/12/lib/libcxxrt/Makefile
  stable/12/lib/libcxxrt/Version.map