Bug 239283 - textproc/sphinxsearch: Update to 3.1.1
Summary: textproc/sphinxsearch: Update to 3.1.1
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthew Seaman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-18 15:20 UTC by Daniel Ylitalo
Modified: 2019-09-04 16:29 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (matthew)


Attachments
Updates port to 3.1.1 (11.83 KB, patch)
2019-07-18 15:20 UTC, Daniel Ylitalo
no flags Details | Diff
Updates port to 3.1.1 (35.67 KB, patch)
2019-07-18 17:31 UTC, Daniel Ylitalo
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Ylitalo 2019-07-18 15:20:14 UTC
Created attachment 205868 [details]
Updates port to 3.1.1

Attached patch passes portlint -AC and poudriere testport

I've kept the old port in textproc/sphinxsearch2 as it is entirely different to the new version for those still needing version 2.

Also worth mentioning is that they do not ship spelldump with version 3 neither do they ship the man pages.

Other than that the port should be identical but it now only extracts the upstream compiled binaries as v3 is closed source until further notice.

Before applying patch issue this:
svn cp textproc/sphinxsearch textproc/sphinxsearch2
Comment 1 Daniel Ylitalo 2019-07-18 17:31:06 UTC
Created attachment 205874 [details]
Updates port to 3.1.1

Forgot to run svn delete on the old patches before doing the diff
Comment 2 Matthew Seaman freebsd_committer 2019-07-18 22:19:51 UTC
Would you like to take maintainership of the new textproc/sphinxsearch you're proposing?
Comment 3 Matthew Seaman freebsd_committer 2019-07-18 22:45:10 UTC
OK, there are a number of things wrong with the patch

  * Binaries are only for amd64 architecture.  This needs to be handled in the
    port
  * You've left in all the OPTIONS definitions, but they don't do anything now
  * The 3.1.1 veresion software is not being distributed under GPLv2.  It can't 
    be, as source code is not available.  I can't find any obvious license text
    in the downloaded tarball nor on the sphinxsearch website.

We're going to need to know precisely what the licensing terms are before we can consider committing this to the ports.
Comment 4 Daniel Ylitalo 2019-07-19 08:03:03 UTC
(In reply to Matthew Seaman from comment #3)

I'm happy with taking maintainership of the new version!

The reason the options are still there for iconv / mysql / postgres is because the precompiled binaries uses them if they are present. I could change this to just have a static dependency on the softwares instead of options, what do you think?

(This is so you don't need to do pkg install sphinxsearch and then do pkg install mysql57-client to have a working software, instead sphinxsearch pulls the clients as in the old version)

I've sent them an email in regards to which license they are using for the precompiled binaries, hopefully they respond soon :)

I'll update the patch once I get a response on the license