Bug 239312 - graphics/dilay: fix build with GCC-based architectures
Summary: graphics/dilay: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-19 18:00 UTC by Piotr Kubaj
Modified: 2019-08-06 19:49 UTC (History)
1 user (show)

See Also:
yuri: maintainer-feedback+


Attachments
patch (712 bytes, patch)
2019-07-19 18:00 UTC, Piotr Kubaj
yuri: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-07-19 18:00:52 UTC
Created attachment 205903 [details]
patch

GCC needs -Wno-narrowing:
src/isosurface-extraction/grid.cpp:309:53: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]

While here also add USES=gl.
Comment 1 commit-hook freebsd_committer 2019-08-06 19:49:02 UTC
A commit references this bug:

Author: pkubaj
Date: Tue Aug  6 19:48:39 UTC 2019
New revision: 508280
URL: https://svnweb.freebsd.org/changeset/ports/508280

Log:
  graphics/dilay: fix build with GCC-based architectures

  GCC needs -Wno-narrowing:
  src/isosurface-extraction/grid.cpp:309:53: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]

  While here also add USES=gl.

  PR:		239312
  Approved by:	yuri (maintainer), tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D21143

Changes:
  head/graphics/dilay/Makefile