Bug 239346 - graphics/librsvg2: drop libgsf and gettext-tools dependencies, add DOCS option
Summary: graphics/librsvg2: drop libgsf and gettext-tools dependencies, add DOCS option
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-07-20 16:19 UTC by Andriy Voskoboinyk
Modified: 2019-07-21 01:15 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gnome)
avos: exp-run?

Attachments
Makefile, pkg-plist and gnome.mk diff (4.99 KB, patch)
2019-07-20 16:19 UTC, Andriy Voskoboinyk 		no flags Details | Diff
Output of portlint -AC (229 bytes, text/plain)
2019-07-20 16:21 UTC, Andriy Voskoboinyk 		no flags Details
12amd64 poudriere build log (DOCS=on) (164.94 KB, text/plain)
2019-07-20 16:22 UTC, Andriy Voskoboinyk 		no flags Details
12amd64 poudriere build log (DOCS=off) (164.95 KB, text/plain)
2019-07-20 16:22 UTC, Andriy Voskoboinyk 		no flags Details
12i386 poudriere build log (DOCS=on) (164.82 KB, text/plain)
2019-07-20 16:23 UTC, Andriy Voskoboinyk 		no flags Details
12i386 poudriere build log (DOCS=off) (164.83 KB, text/plain)
2019-07-20 16:24 UTC, Andriy Voskoboinyk 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer 2019-07-20 16:19:16 UTC 
Created attachment 205939 [details]
Makefile, pkg-plist and gnome.mk diff

Remove devel/libgsf dependency since was removed some time ago (entry from ChangeLog):

commit 59a3fed362fd70e29452fce58d8324cc00e7cc7e
Author: Christian Persch <chpe@gnome.org>
Date:   Sat Oct 22 19:03:27 2011 +0200

    Drop GSF support
    
    Update GIO req to 2.24, and just always use GIO for gzip support.

and remove it from Mk/Uses/gnome.mk accordingly (probably requires an exp-run).

Remove gettext-tools build dependency too (not used by the port).

While here, sort USES / DEPENDS (portlint) and add DOCS option (checked locally with make DOCSDIR=/opt/share/doc).

Bump PORTREVISION since the package will change.
Comment 1 Andriy Voskoboinyk freebsd_committer 2019-07-20 16:21:09 UTC 
Created attachment 205940 [details]
Output of portlint -AC
Comment 2 Andriy Voskoboinyk freebsd_committer 2019-07-20 16:22:28 UTC 
Created attachment 205942 [details]
12amd64 poudriere build log (DOCS=on)
Comment 3 Andriy Voskoboinyk freebsd_committer 2019-07-20 16:22:52 UTC 
Created attachment 205944 [details]
12amd64 poudriere build log (DOCS=off)
Comment 4 Andriy Voskoboinyk freebsd_committer 2019-07-20 16:23:40 UTC 
Created attachment 205945 [details]
12i386 poudriere build log (DOCS=on)
Comment 5 Andriy Voskoboinyk freebsd_committer 2019-07-20 16:24:14 UTC 
Created attachment 205946 [details]
12i386 poudriere build log (DOCS=off)
Comment 6 Andriy Voskoboinyk freebsd_committer 2019-07-21 01:15:00 UTC 
patch-ready -> patch (looks like I should not set this flag - from https://wiki.freebsd.org/KubilayKocak/Bugzilla/DosAndDonts )