Bug 239380 - sys.netpfil.pf.forward.{v4,v6} and sys.netpfil.pf.set_tos.v4 fail on i386
Summary: sys.netpfil.pf.forward.{v4,v6} and sys.netpfil.pf.set_tos.v4 fail on i386
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: CURRENT
Hardware: i386 Any
: --- Affects Many People
Assignee: freebsd-testing mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-22 14:23 UTC by Li-Wen Hsu
Modified: 2019-09-17 21:39 UTC (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Li-Wen Hsu freebsd_committer 2019-07-22 14:23:35 UTC
These 3 tests always fail on i386:

sys.netpfil.pf.forward.v4
sys.netpfil.pf.forward.v6
sys.netpfil.pf.set_tos.v4

There are some analysis from kp@:

https://lists.freebsd.org/pipermail/freebsd-testing/2019-June/001933.html
https://lists.freebsd.org/pipermail/freebsd-testing/2019-June/001934.html
Comment 1 commit-hook freebsd_committer 2019-07-22 18:55:23 UTC
A commit references this bug:

Author: lwhsu
Date: Mon Jul 22 18:54:26 UTC 2019
New revision: 350221
URL: https://svnweb.freebsd.org/changeset/base/350221

Log:
  Temporarily skip sys.netpfil.pf.forward.{v4,v6} and sys.netpfil.pf.set_tos.v4
  on i386 as they are flakey on it

  PR:		239380
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/tests/sys/netpfil/pf/forward.sh
  head/tests/sys/netpfil/pf/set_tos.sh
Comment 2 commit-hook freebsd_committer 2019-07-23 08:21:30 UTC
A commit references this bug:

Author: lwhsu
Date: Tue Jul 23 08:20:53 UTC 2019
New revision: 350237
URL: https://svnweb.freebsd.org/changeset/base/350237

Log:
  MFC r350221

  Temporarily skip sys.netpfil.pf.forward.{v4,v6} and sys.netpfil.pf.set_tos.v4
  on i386 as they are flakey on it

  PR:		239380
  Sponsored by:	The FreeBSD Foundation

Changes:
_U  stable/12/
  stable/12/tests/sys/netpfil/pf/forward.sh
  stable/12/tests/sys/netpfil/pf/set_tos.sh
Comment 3 Ed Maste freebsd_committer 2019-08-12 19:29:45 UTC
(In reply to Li-Wen Hsu from comment #0)
kp suggests it appears to be a bpf issue
Comment 4 Kristof Provost freebsd_committer 2019-09-03 15:27:55 UTC
It looks like I was wrong and this isn't actually a problem in bpf, but with scapy itself.
With scapy-2.3.3 the tests pass, with py27-scapy-2.4.2_2 they do not.
Comment 5 commit-hook freebsd_committer 2019-09-05 13:26:57 UTC
A commit references this bug:

Author: bofh
Date: Thu Sep  5 13:26:15 UTC 2019
New revision: 511187
URL: https://svnweb.freebsd.org/changeset/ports/511187

Log:
  net/scapy: Update version 2.4.2=>2.4.3

  - Use net/py-pypcap instead of net/py-pcap as dnet and py-pcap will be
    deprecated in future scapy versions. One other reason is py-pcap is
    failing with python3. [1]

  PR:		239380 [1]
  Submitted by:	lwhsu [1]

Changes:
  head/net/scapy/Makefile
  head/net/scapy/distinfo
  head/net/scapy/files/
Comment 6 commit-hook freebsd_committer 2019-09-11 10:24:52 UTC
A commit references this bug:

Author: bofh
Date: Wed Sep 11 10:24:29 UTC 2019
New revision: 511811
URL: https://svnweb.freebsd.org/changeset/ports/511811

Log:
  inet/scapy: Update version 2.4.2=>2.4.3

  - Use net/py-pypcap instead of net/py-pcap as dnet and py-pcap will be
    deprecated in future scapy versions. One other reason is py-pcap is
    failing with python3. [1]
  - Change MASTER_SITE to PYPI for better availability [2]
  - Update WWW [2]

  PR:		239380 [1] 240493 [2]
  Submitted by:	lwhsu [1] [2]

Changes:
  head/net/scapy/Makefile
  head/net/scapy/distinfo
  head/net/scapy/files/
  head/net/scapy/pkg-descr
Comment 8 Muhammad Moinur Rahman freebsd_committer 2019-09-17 19:02:15 UTC
(In reply to Li-Wen Hsu from comment #7)
Is it possible to comment out the RUN_DEPENDS and rerun the test without committing ?
Comment 9 Li-Wen Hsu freebsd_committer 2019-09-17 19:10:26 UTC
(In reply to Muhammad Moinur Rahman from comment #8)
It's possible by manually building the package and installing to the VM.  Do you mean all the RUN_DEPENDS?  Can you provide a patch?
Comment 10 Li-Wen Hsu freebsd_committer 2019-09-17 21:39:45 UTC
I tried to remove py27-pypcap-1.2.3, libdnet-1.13_3, py27-libdnet-1.13_3 with `pkg -f` to keep py27-scapy-2.4.3, but the tests are still failing.