Bug 239412 - x11/nvidia-driver (390.87_3) incorrectly describes how to add kmod to loader.conf
Summary: x11/nvidia-driver (390.87_3) incorrectly describes how to add kmod to loader....
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-23 21:38 UTC by aryeh.friedman
Modified: 2019-07-24 00:53 UTC (History)
1 user (show)

See Also:
linimon: maintainer-feedback? (danfe)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description aryeh.friedman 2019-07-23 21:38:45 UTC
In an old PR (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212279) it was stated that the documentation for x11/nvidia-driver (both the older version and the current one given in the summary line) incorrectly state to *ONLY* add the enable line for nvidia-modeset to loader.conf when in fact plane nvidia also needs to be loaded.

I.e. the following will not load correctly:

...
nvidia-modeset_load="YES"
...

but: 

...
nvidia_load="YES"
nvidia-modeset_load="YES"
...

will load correctly.

For reference here is my complete loader.conf:

vfs.root.mountfrom="zfs:zroot/ROOT/default"
kern.geom.label.disk_ident.enable="0"
kern.geom.label.gptid.enable="0"
zfs_load="YES"
zpool_cache_load="YES"
zpool_cache_type="/boot/zfs/zpool.cache"
zpool_cache_name="/boot/zfs/zpool.cache"
linux_enable="YES"
nvidia_load="YES"
nvidia-modeset_load="YES"
kern.cam.da.default_timeout="5"
autofs_load="YES"

And my uname -a:

FreeBSD lilith 11.2-RELEASE-p10 FreeBSD 11.2-RELEASE-p10 #1 r349114: Sun Jun 16 12:44:01 EDT 2019     root@lilith:/usr/obj/usr/src/sys/GENERIC  amd64
Comment 1 Alex S 2019-07-23 22:21:14 UTC
(In reply to aryeh.friedman from comment #0)

> I.e. the following will not load correctly:
> nvidia-modeset_load="YES"
Nah, nvidia.ko is a dependency of nvidia-modeset.ko, so it will be loaded automatically.

> In an old PR (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212279)
> it was stated that the documentation for x11/nvidia-driver incorrectly state to *ONLY*
> add the enable line for nvidia-modeset to loader.conf when in fact plane nvidia also needs to be loaded
There is not mention of the word "documentation" in that PR. The suggestion was to patch the driver's bundled kernel modules to make nvidia-modeset.ko a dependency of nvidia.ko for a bit of (setup) consistency with previous driver versions.

The thing is, Nvidia in general knows better what to do with their driver. If they did set module dependencies in a specific way it was probably for a reason. It is wiser leave that untouched.