Bug 239420 - devel/crc32c: fix build on big-endian architectures
Summary: devel/crc32c: fix build on big-endian architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-24 07:30 UTC by Piotr Kubaj
Modified: 2019-08-01 19:13 UTC (History)
1 user (show)

See Also:
linimon: maintainer-feedback+

Attachments
patch (2.49 KB, patch)
2019-07-24 07:30 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (amzo1337)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-07-24 07:30:19 UTC 
Created attachment 206029 [details]
patch

C++11 compiler is needed:
  Target "crc32c" requires the language dialect "CXX11" , but CMake does not
  know the compile flags to use to enable it.

Additionally, big-endian code in src/crc32c_read_le.h needs fixing - the value is 64 bits wide, not 32 bits.
Comment 1 Anthony Donnelly 2019-07-24 13:31:04 UTC 
I see no problem with this. It was quickly made as it was a dependency for Tensorflow which i'm currently working on.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-08-01 19:13:09 UTC 
A commit references this bug:

Author: pkubaj
Date: Thu Aug  1 19:12:17 UTC 2019
New revision: 507823
URL: https://svnweb.freebsd.org/changeset/ports/507823

Log:
  devel/crc32c: fix build on big-endian architectures

  C++11 compiler is needed:

  Target "crc32c" requires the language dialect "CXX11" , but CMake does not
  know the compile flags to use to enable it.

  Additionally, big-endian code in src/crc32c_read_le.h needs fixing - the value is 64 bits wide, not 32 bits.

  PR:		239420
  Approved by:	amzo1337@gmail.com (maintainer), tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D21054

Changes:
  head/devel/crc32c/Makefile
  head/devel/crc32c/files/
  head/devel/crc32c/files/patch-src_crc32c__read__le.h