Bug 239437 - audio/mixxx: fix build on non-x86
Summary: audio/mixxx: fix build on non-x86
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-25 07:22 UTC by Piotr Kubaj
Modified: 2019-08-13 01:33 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (acm)


Attachments
patch (1.83 KB, patch)
2019-07-25 07:22 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (acm)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-07-25 07:22:08 UTC
Created attachment 206048 [details]
patch

Don't optimize for native. It optimizes for the compiling CPU which may break runtime on the user CPU.

It also breaks compilation e.g. on powerpc64, -march=native is not available there. Bump PORTREVISION because of package change.

Also include sys/types.h in plugins/soundsourcem4a/soundsourcem4a.h for uint (needed by GCC).
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-08-02 14:23:26 UTC
This builds for me on both amd64 and powerpc64.
Comment 2 commit-hook freebsd_committer 2019-08-13 01:32:59 UTC
A commit references this bug:

Author: acm
Date: Tue Aug 13 01:32:49 UTC 2019
New revision: 508806
URL: https://svnweb.freebsd.org/changeset/ports/508806

Log:
  - Fix build on non-x86
  - Fix build on powerpc64

  PR:		239437
  Submitted by:	pkubaj

Changes:
  head/audio/mixxx/Makefile
  head/audio/mixxx/files/patch-plugins_soundsourcem4a_soundsourcem4a.h