Bug 239459 - devel/electron4 - Makefile post build issue
Summary: devel/electron4 - Makefile post build issue
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Luca Pizzamiglio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-26 08:20 UTC by Sebastian Stroniewski-Wojtczak
Modified: 2019-07-29 21:49 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (tagattie)


Attachments
Patch to fix pkg-plist when DIST is OFF (2.14 KB, patch)
2019-07-29 11:31 UTC, Hiroki Tagato
tagattie: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Stroniewski-Wojtczak 2019-07-26 08:20:35 UTC
Hi,

tags: "post-build" and "post-build-DIST-on" in Makefile are not triggered so few files cannot be copied/created:

pkg-static: Unable to access file /tmp/var/db/repo/ports/devel/electron4/work/stage/usr/local/share/electron/releases/SHASUMS256.txt:No such file or directory
pkg-static: Unable to access file /tmp/var/db/repo/ports/devel/electron4/work/stage/usr/local/share/electron/releases/chromedriver-v4.2.8-freebsd-x64.zip:No such file or directory
pkg-static: Unable to access file /tmp/var/db/repo/ports/devel/electron4/work/stage/usr/local/share/electron/releases/electron-v4.2.8-freebsd-x64.zip:No such file or directory
pkg-static: Unable to access file /tmp/var/db/repo/ports/devel/electron4/work/stage/usr/local/share/electron/releases/mksnapshot-v4.2.8-freebsd-x64.zip:No such file or directory

I had to manually run:
$> make post-build
$> make post-build-DIST-on

Once I got such files I was able to install/package electron4.

Thanks
Sebastian Stroniewski-Wojtczak
Comment 1 Hiroki Tagato 2019-07-26 09:50:43 UTC
(In reply to Sebastian Stroniewski-Wojtczak from comment #0)

Hi Sebastian,

Thanks for reporting the issue.

I guess the port option DIST is set OFF. Is that correct? If so, this seems an issue with pkg-plist and I will look into this.
Comment 2 Hiroki Tagato 2019-07-29 11:31:10 UTC
Created attachment 206139 [details]
Patch to fix pkg-plist when DIST is OFF

The failure of build was due to an error in "pkg-plist", which forced a build process to unconditionally try to include the listed files in a package.

The attached patch fixes the error and also changes the DIST option to OFF by default (since including the binary zip files currently doesn't make much sense).
Comment 3 commit-hook freebsd_committer 2019-07-29 21:48:19 UTC
A commit references this bug:

Author: pizzamig
Date: Mon Jul 29 21:47:27 UTC 2019
New revision: 507605
URL: https://svnweb.freebsd.org/changeset/ports/507605

Log:
  devel/electron4: Fix pkg-plist and change default options

  Fix pkg-plist when DIST option is OFF.
  The DIST option is set OFF by default, reducing the package size.
  Bump PORTREVISION.

  PR:		239459
  Submitted by:	maintainer
  Reported by:	Sebastian Stroniewski-Wojtczak
  Obtained from:	https://github.com/tagattie/FreeBSD-Electron/pull/16

Changes:
  head/devel/electron4/Makefile
  head/devel/electron4/pkg-plist
Comment 4 Luca Pizzamiglio freebsd_committer 2019-07-29 21:49:06 UTC
Committed!
Thanks for reporting!