Bug 239497 - net/frr5 rc.d/frr doesn't start daemon in integrated configuration mode
Summary: net/frr5 rc.d/frr doesn't start daemon in integrated configuration mode
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Olivier Cochard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-28 15:42 UTC by nicolas
Modified: 2020-02-10 16:39 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (olivier)


Attachments
Patch (786 bytes, patch)
2019-07-28 15:42 UTC, nicolas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nicolas 2019-07-28 15:42:15 UTC
Created attachment 206122 [details]
Patch

Issue:
/etc/rc.d/frr start does't start daemon if etc/frr/${daemon}.conf doesn't exit even if vtysh_boot is set to YES.

Integrated configuration mode use only frr.conf and so didn't require per daemon configuration files.
When daemons start, if ${daemon}.conf didn't exist daemon read frr.conf.

Solution:
Apply the attached patch.
Comment 1 nicolas 2019-07-28 18:26:45 UTC
This bug exist only in frr5.
Comment 2 commit-hook freebsd_committer 2020-02-10 16:26:16 UTC
A commit references this bug:

Author: olivier
Date: Mon Feb 10 16:25:53 UTC 2020
New revision: 525713
URL: https://svnweb.freebsd.org/changeset/ports/525713

Log:
  - Fix starting daemon in integrated configuration mode
  - While here, add 'dynamicrouting' to RC's PROVIDE and fix Makefile order

  PR:		239497
  Submitted by:	Nicolas Deffayet <nicolas@deffayet.com>

Changes:
  head/net/frr5/Makefile
  head/net/frr5/files/frr.in
Comment 3 Olivier Cochard freebsd_committer 2020-02-10 16:39:15 UTC
Thanks for your patch... and patience too :-)