Bug 239540 - www/mitmproxy: Prepare for py-openssl 19.0.0 and unbreak at runtime
Summary: www/mitmproxy: Prepare for py-openssl 19.0.0 and unbreak at runtime
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL:
Keywords:
Depends on:
Blocks: 237006
  Show dependency treegraph
 
Reported: 2019-07-30 19:38 UTC by Kai Knoblich
Modified: 2019-08-04 21:18 UTC (History)
1 user (show)

See Also:
gaod: maintainer-feedback+
kai: merge-quarterly+


Attachments
mitmproxy-prepare-for-py-openssl-and-fix-runtime-error.patch (1.50 KB, patch)
2019-07-30 19:38 UTC, Kai Knoblich
kai: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer 2019-07-30 19:38:01 UTC
Created attachment 206163 [details]
mitmproxy-prepare-for-py-openssl-and-fix-runtime-error.patch

Hi,

attached is a patch that does following actions to www/mitmproxy:

- Relax the requirements for security/py-openssl (to update that port to 19.0.0)
- Since security/py-cryptography has been updated to 2.6 in ports r496506 www/mitmproxy fails at runtime. Thus also relax the requirements for security/py-cryptography and unbreak it.

QA:
~~~
- poudriere (11.2-, 11.3-, 12.0-RELEASE, 13.0-CURRENT@r349352 amd64 + i386) -> OK
Comment 1 Hung-Yi Chen 2019-08-04 16:45:07 UTC
Looks good to me. Thanks very much.
Comment 2 commit-hook freebsd_committer 2019-08-04 21:12:50 UTC
A commit references this bug:

Author: kai
Date: Sun Aug  4 21:12:29 UTC 2019
New revision: 508126
URL: https://svnweb.freebsd.org/changeset/ports/508126

Log:
  www/mitmproxy: Prepare for py-openssl 19.0.0 and unbreak at runtime

  Relax the version ranges for security/py-openssl to avoid breakage at
  runtime when release 19.0.0 lands into the Ports tree.

  Also unbreak the port as it's already broken at runtime because the given
  requirements for security/py-cryptography are too narrow.

  PR:		239540
  Approved by:	Hung-Yi Chen <gaod@hychen.org> (maintainer)
  MFH:		2019Q3 (runtime fix)

Changes:
  head/www/mitmproxy/Makefile
  head/www/mitmproxy/files/patch-setup.py
Comment 3 commit-hook freebsd_committer 2019-08-04 21:15:51 UTC
A commit references this bug:

Author: kai
Date: Sun Aug  4 21:15:37 UTC 2019
New revision: 508127
URL: https://svnweb.freebsd.org/changeset/ports/508127

Log:
  MFH: r508126

  www/mitmproxy: Prepare for py-openssl 19.0.0 and unbreak at runtime

  Relax the version ranges for security/py-openssl to avoid breakage at
  runtime when release 19.0.0 lands into the Ports tree.

  Also unbreak the port as it's already broken at runtime because the given
  requirements for security/py-cryptography are too narrow.

  PR:		239540
  Approved by:	Hung-Yi Chen <gaod@hychen.org> (maintainer)
  Approved by:	ports-secteam blanket (runtime fix)

Changes:
_U  branches/2019Q3/
  branches/2019Q3/www/mitmproxy/Makefile
  branches/2019Q3/www/mitmproxy/files/patch-setup.py
Comment 4 Kai Knoblich freebsd_committer 2019-08-04 21:17:26 UTC
Comment on attachment 206163 [details]
mitmproxy-prepare-for-py-openssl-and-fix-runtime-error.patch

Approved by maintainer
Comment 5 Kai Knoblich freebsd_committer 2019-08-04 21:18:50 UTC
Thank you for your review and approval, the changes have been committed to the head and 2019Q3 branch!