Bug 239580 - [patch] ports-mgmt/pkg builds pkg-static during staging phase
Summary: [patch] ports-mgmt/pkg builds pkg-static during staging phase
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-pkg mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-01 16:23 UTC by Maxim Sobolev
Modified: 2020-03-24 17:11 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (pkg)


Attachments
Patch to fix the issue. (828 bytes, text/plain)
2019-08-01 16:23 UTC, Maxim Sobolev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Sobolev freebsd_committer 2019-08-01 16:23:43 UTC
Created attachment 206203 [details]
Patch to fix the issue.

There what seems to be an error in the Makefile.autosetup, which causes pkg-static to be linked in during install-static stage, not during make all stage, which violates porting guidelines. Attached patch fixes the issue.

00:08:38.439  ===>  Staging for pkg-1.11.1
00:08:38.439  ===>   Generating temporary packing list
[...]
00:08:38.439  install: DONTSTRIP set - will not strip installed binaries
00:08:38.439  cc -o pkg-static add.o alias.o annotate.o audit.o autoremove.o backup.o check.o clean.o config.o create.o delete.o event.o fetch.o globals.o info.o install.o lock.o main.o plugins.o query.o register.o repo.o rquery.o search.o set.o shell.o shlib.o ssh.o stats.o update.o updating.o upgrade.o utils.o version.o which.o -static  -fstack-protector-strong  -L/tmp/usr/ports/ports-mgmt/pkg/work/pkg-1.11.1/libpkg -lpkg_flat  -lelf -ljail -larchive -lbz2 -lz -llzma -lm -lssl -lcrypto -pthread -lutil
00:08:38.711  install -d -m 755 /tmp/usr/ports/ports-mgmt/pkg/work/stage/usr/local/sbin
00:08:38.711  install: DONTSTRIP set - will not strip installed binaries
00:08:38.711  install -s -m 755 pkg-static /tmp/usr/ports/ports-mgmt/pkg/work/stage/usr/local/sbin/pkg-static
Comment 1 Baptiste Daroussin freebsd_committer 2020-03-24 17:11:45 UTC
thanks