Bug 239630 - x11/libxshmfence: prefer SHM_ANON over mksotemp()
Summary: x11/libxshmfence: prefer SHM_ANON over mksotemp()
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-08-03 21:30 UTC by Jan Beich
Modified: 2021-05-27 03:32 UTC (History)
2 users (show)

See Also:
jkim: maintainer-feedback+

Attachments
v1 (has commit message) (1.54 KB, patch)
2019-08-03 21:30 UTC, Jan Beich 		jbeich: maintainer-approval? (x11)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2019-08-03 21:30:03 UTC 
Created attachment 206257 [details]
v1 (has commit message)

SHM_ANON is faster and more similar to memfd_create(). Not bothering to upstream because futex/mksotemp fixes didn't get any feedback after 2 years. Patchwork is complete crap for one-off contributors i.e., those humble enough to not annoy everyone on patch maillist why their contribution wasn't reviewed yet.

libxshmfence is only used by DRI3, so make sure to define LIBGL_DRI3_ENABLE via environ(7) due to drm-legacy-kmod hacks in mesa-dri and if using xf86-video-intel add Option "DRI" "3" to xorg.conf.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2019-08-03 21:57:54 UTC 
Sorry the rant. I've missed upstream move to GitLab.
https://gitlab.freedesktop.org/xorg/lib/libxshmfence/merge_requests/1
Comment 2 Jan Beich freebsd_committer freebsd_triage 2021-05-10 03:10:10 UTC 
Ping. This may help https://forums.freebsd.org/threads/xorg-high-disk-i-o-activity.79398/
Comment 3 Jan Beich freebsd_committer freebsd_triage 2021-05-13 21:23:37 UTC 
Ping. SHM_ANON is for FreeBSD < 13 as later versions have memfd_create.
Comment 4 Jan Beich freebsd_committer freebsd_triage 2021-05-20 15:09:00 UTC 
Ping.
Comment 5 Jan Beich freebsd_committer freebsd_triage 2021-05-25 12:58:53 UTC 
Ping?
Comment 6 Jung-uk Kim freebsd_committer freebsd_triage 2021-05-26 03:21:45 UTC 
LGTM
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-05-27 03:32:18 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f783260c1c4d7bacbb6d36cab209eab28da49d4e

commit f783260c1c4d7bacbb6d36cab209eab28da49d4e
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2019-08-03 21:14:43 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-05-27 03:30:56 +0000

    x11/libxshmfence: prefer SHM_ANON over mksotemp()

    SHM_ANON is faster and more similar to memfd_create()

    PR:             239630
    Approved by:    jkim

 x11/libxshmfence/Makefile                           |  1 +
 x11/libxshmfence/files/patch-src__xshmfence_alloc.c | 12 +++++++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)