Bug 239633 - games/openxcom: fix build with GCC-based architectures
Summary: games/openxcom: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-03 22:37 UTC by Piotr Kubaj
Modified: 2019-08-14 17:14 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (amdmi3)


Attachments
patch (4.99 KB, patch)
2019-08-03 22:37 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (amdmi3)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-08-03 22:37:20 UTC
Created attachment 206260 [details]
patch

This port needs a bunch of #include <algorithm> to build with GCC. Example of error:
Savegame/Craft.cpp:169:83: error: no matching function for call to 'find(std::vector<std::__cxx11::basic_string<char> >::const_iterator, std::vector<std::__cxx11::basic_string<char>
>::const_iterator, const std::__cxx11::basic_string<char>&)'


Also add USES=gl sdl.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-08-07 09:34:02 UTC
I can confirm this builds on both amd64 and powerpc64.
Comment 2 commit-hook freebsd_committer 2019-08-14 17:14:39 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Aug 14 17:14:25 UTC 2019
New revision: 508940
URL: https://svnweb.freebsd.org/changeset/ports/508940

Log:
  - Fix build with GCC-based architectures

  PR:		239633
  Submitted by:	pkubaj@FreeBSD.org

Changes:
  head/games/openxcom/Makefile
  head/games/openxcom/files/patch-src_Engine_Language.cpp
  head/games/openxcom/files/patch-src_Engine_OptionInfo.cpp
  head/games/openxcom/files/patch-src_Menu_ListGamesState.cpp
  head/games/openxcom/files/patch-src_Menu_ListLoadState.cpp
  head/games/openxcom/files/patch-src_Savegame_Craft.cpp