Bug 239690 - audio/libmysofa: Update to 0.7
Summary: audio/libmysofa: Update to 0.7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jan Beich
URL: https://github.com/hoene/libmysofa/re...
: 239828 (view as bug list)
Depends on:
Reported: 2019-08-07 11:19 UTC by Oleg Sidorkin
Modified: 2019-09-08 09:35 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (jhale)
koobs: merge-quarterly?

patch to update audio/libmysofa 0.6 -> 0.7 (1.24 KB, patch)
2019-08-07 11:19 UTC, Oleg Sidorkin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Sidorkin 2019-08-07 11:19:50 UTC
Created attachment 206327 [details]
patch to update audio/libmysofa 0.6 -> 0.7

This patch also fixes the following error in multimedia/ffmpeg build with SOFA filter enabled:

libavfilter/af_sofalizer.c:166:32: error: implicit declaration of function 'mysofa_neighborhood_init_withstepdefine' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        s->sofa.neighborhood = mysofa_neighborhood_init_withstepdefine(s->sofa.hrtf,
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-07 11:40:08 UTC
Bugfix release and port bugfix, MFH
Comment 2 commit-hook freebsd_committer 2019-08-14 10:35:03 UTC
A commit references this bug:

Author: jbeich
Date: Wed Aug 14 10:34:49 UTC 2019
New revision: 508906
URL: https://svnweb.freebsd.org/changeset/ports/508906

  audio/libmysofa: update to 0.7

  Changes:	https://github.com/hoene/libmysofa/releases/tag/v0.7
  PR:		239690
  Submitted by:	Oleg Sidorkin
  MFH:		2019Q3

Comment 3 Jan Beich freebsd_committer 2019-08-14 10:45:25 UTC
Looks like jhale@ is inactive, so I didn't wait for timeout.
Comment 4 Jan Beich freebsd_committer 2019-08-14 10:48:48 UTC
*** Bug 239828 has been marked as a duplicate of this bug. ***
Comment 5 Jan Beich freebsd_committer 2019-08-27 16:59:49 UTC
port-secteam@ timeout. Resetting MFH request.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-28 02:53:28 UTC
Note: Bugfix commits/releases are part of blanket/implicit approvals for MFH, not requiring explicit approval

ports r508906 can be MFH'd immediately
Comment 7 Jan Beich freebsd_committer 2019-08-28 06:59:45 UTC
v0.7 doesn't consist entirely of bug fixes e.g.,
- https://github.com/hoene/libmysofa/pull/40
- https://github.com/hoene/libmysofa/pull/44
- https://github.com/hoene/libmysofa/pull/53
Comment 8 Oleg Sidorkin 2019-08-28 12:19:05 UTC
Sorry for my 2 cents:

The cause of the problem is ffmpeg 4.2 dependence on https://github.com/hoene/libmysofa/pull/53

ffmpeg 4.1.4 is ok with libmysofa-0.6