Bug 239739 - factor out hardcoding of "clangXYZ" in math/libpgmath
Summary: factor out hardcoding of "clangXYZ" in math/libpgmath
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Johannes M Dieterich
URL:
Keywords:
Depends on:
Blocks: 239736
  Show dependency tree / graph
 
Reported: 2019-08-09 10:42 UTC by Mark Linimon
Modified: 2019-10-04 22:13 UTC (History)
0 users

See Also:
jmd: maintainer-feedback+

Attachments
patch to math/libpgmath/Makefile (911 bytes, patch)
2019-08-09 10:42 UTC, Mark Linimon 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon freebsd_committer freebsd_triage 2019-08-09 10:42:11 UTC 
Created attachment 206391 [details]
patch to math/libpgmath/Makefile

There are a number of places in the ports tree where the string "clang<version" is called out.  When doing the work to identify stale versions of clang tree-wide, these instances cause extra work.

Refactor this usage into LLVM_VER.

Note: this refactoring causes portlint to complain but IMHO this complication is worth tolerating to help ease maintainability.

Tested on: amd64.
Comment 1 Johannes M Dieterich freebsd_committer freebsd_triage 2019-08-20 03:08:57 UTC 
LGTM
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2019-10-04 22:13:58 UTC 
Committed, thanks.