Bug 239741 - factor out hardcoding of "clangXYZ" in graphics/openshadinglanguage
Summary: factor out hardcoding of "clangXYZ" in graphics/openshadinglanguage
Status: Closed DUPLICATE of bug 239588
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mark Linimon
Depends on:
Blocks: 239736
  Show dependency treegraph
Reported: 2019-08-09 10:45 UTC by Mark Linimon
Modified: 2019-08-14 09:43 UTC (History)
1 user (show)

See Also:
linimon: maintainer-feedback+

patch to graphics/openshadinglanguage/Makefile (1.13 KB, patch)
2019-08-09 10:45 UTC, Mark Linimon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon freebsd_committer freebsd_triage 2019-08-09 10:45:06 UTC
Created attachment 206393 [details]
patch to graphics/openshadinglanguage/Makefile

There are a number of places in the ports tree where the string "clang<version" is called out.  When doing the work to identify stale versions of clang tree-wide, these instances cause extra work.

Refactor this usage into LLVM_VER.

Note: this refactoring causes portlint to complain but IMHO this complication is worth tolerating to help ease maintainability.
Comment 1 Shane 2019-08-14 02:43:52 UTC
doesn't accept me adding maintainer approval.

This change has been merged into pending update in bug #239588
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2019-08-14 09:43:12 UTC
Change now included in 239588 .

*** This bug has been marked as a duplicate of bug 239588 ***