Bug 239855 - mail/p5-Mail-SPF: Unbreak parsing SPF records
Summary: mail/p5-Mail-SPF: Unbreak parsing SPF records
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Sunpoet Po-Chuan Hsieh
URL: http://debian.2.n7.nabble.com/Bug-461...
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-14 14:29 UTC by Michael Gmelin
Modified: 2019-08-14 18:03 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
Patch to fix problem described in bug description (1.29 KB, patch)
2019-08-14 14:29 UTC, Michael Gmelin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Gmelin freebsd_committer 2019-08-14 14:29:07 UTC
Created attachment 206539 [details]
Patch to fix problem described in bug description

In certain code paths Mail/SPF will fail to parse SPF records correctly due to not importing/requiring Mail::SPF::Mech (which contains class methods required in the parse process).

This is a fairly old problem, this bug report with a supposed fix by the author also contained the patch I included here:

http://debian.2.n7.nabble.com/Bug-461709-usr-sbin-spamd-spf-lookup-failed-Can-t-locate-object-method-quot-new-quot-via-package-quo-td492057.html

I will also report upstream, but as this problem leads to skipping SPF sometimes in mail/spampd (and probably SpamAssassin in general) I felt that pulling this into the ports tree now makes a lot of sense.

Symptom:
Aug 14 13:06:40 mail spampd[66621]: spf: lookup failed: Can't locate object method "qualifier_pattern" via package "Mail::SPF::Mech" at /usr/local/lib/perl5/site_perl/Mail/SPF/Record.pm line 213.
Comment 1 Michael Gmelin freebsd_committer 2019-08-14 14:52:14 UTC
(In reply to Michael Gmelin from comment #0)

Bug report at CPAN:
https://rt.cpan.org/Ticket/Display.html?id=130299
Comment 2 commit-hook freebsd_committer 2019-08-14 18:02:44 UTC
A commit references this bug:

Author: sunpoet
Date: Wed Aug 14 18:02:15 UTC 2019
New revision: 508957
URL: https://svnweb.freebsd.org/changeset/ports/508957

Log:
  Fix parsing SPF records

  - Bump PORTREVISION for package change

  PR:		239855
  Submitted by:	grembo
  Reference:	http://debian.2.n7.nabble.com/Bug-461709-usr-sbin-spamd-spf-lookup-failed-Can-t-locate-object-method-quot-new-quot-via-package-quo-td492057.html
  		https://rt.cpan.org/Public/Bug/Display.html?id=130299

Changes:
  head/mail/p5-Mail-SPF/Makefile
  head/mail/p5-Mail-SPF/files/
  head/mail/p5-Mail-SPF/files/patch-lib-Mail-SPF-Record.pm
Comment 3 Sunpoet Po-Chuan Hsieh freebsd_committer 2019-08-14 18:03:33 UTC
Committed. Thanks!