Bug 239866 - finance/cointop: Switch to USES=go:modules, fix build with go1.13
Summary: finance/cointop: Switch to USES=go:modules, fix build with go1.13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-14 20:20 UTC by Dmitri Goutnik
Modified: 2019-08-17 02:06 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ndowens04)

Attachments
patch file (901 bytes, patch)
2019-08-14 20:20 UTC, Dmitri Goutnik 		dmgk: maintainer-approval? (ndowens04)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer 2019-08-14 20:20:44 UTC 
Created attachment 206555 [details]
patch file

===>  Building for cointop-1.1.2
$GOPATH/go.mod exists but should not
*** Error code 1

- Switch to USES=go:modules, this also fixes the build with go1.13
- Remove custom targets

QA:
  poudriere testport: OK (120a-go1.12.8, 120a-go-devel)
Comment 1 Yuri Victorovich freebsd_committer 2019-08-17 02:06:11 UTC 
Committed, thanks!
Comment 2 commit-hook freebsd_committer 2019-08-17 02:06:39 UTC 
A commit references this bug:

Author: yuri
Date: Sat Aug 17 02:06:06 UTC 2019
New revision: 509135
URL: https://svnweb.freebsd.org/changeset/ports/509135

Log:
  finance/cointop: Switch to USES=go:modules, fix build with go1.13

  PR:		239866
  Submitted by:	Dmitri Goutnik <dg@syrec.org>
  Approved by:	portmgr (unbreak with the upcoming go1.13)

Changes:
  head/finance/cointop/Makefile