Bug 239880 - databases/redis_exporter: Switch to USES=go:modules, fix build with go1.13
Summary: databases/redis_exporter: Switch to USES=go:modules, fix build with go1.13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-15 14:46 UTC by Dmitri Goutnik
Modified: 2019-08-17 02:08 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (arcade)


Attachments
patch file (780 bytes, patch)
2019-08-15 14:46 UTC, Dmitri Goutnik
dmgk: maintainer-approval? (arcade)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer 2019-08-15 14:46:15 UTC
Created attachment 206580 [details]
patch file

===>  Building for redis_exporter-1.0.3
go: github.com/golang/protobuf@v1.3.1: Get https://proxy.golang.org/github.com/golang/protobuf/@v/v1.3.1.mod: dial tcp: lookup proxy.golang.org on 1.0.0.1:53: write udp 127.0.0.1:11789->1.0.0.1:53: write: permission denied
*** Error code 1

- Switch to USES=go:modules, this also fixes the build with go1.13
- Remove custom do-install target
- Remove GO_PKGNAME and GO_TARGET (not needed after r507340)

QA:
  poudriere testport: OK (120a-go1.12.8, 120a-go-devel)
Comment 1 commit-hook freebsd_committer 2019-08-17 01:58:36 UTC
A commit references this bug:

Author: yuri
Date: Sat Aug 17 01:58:32 UTC 2019
New revision: 509133
URL: https://svnweb.freebsd.org/changeset/ports/509133

Log:
  databases/redis_exporter: Switch to USES=go:modules, fix build with go1.13

  PR:		239880
  Submitted by:	Dmitri Goutnik <dg@syrec.org>
  Approved by:	portmgr (unbreak with the upcoming go1.13)

Changes:
  head/databases/redis_exporter/Makefile
Comment 2 Yuri Victorovich freebsd_committer 2019-08-17 01:58:52 UTC
Committed, thanks!