Bug 239881 - textproc/fzf: Switch to USES=go:modules, fix build with go1.13
Summary: textproc/fzf: Switch to USES=go:modules, fix build with go1.13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-15 14:53 UTC by Dmitri Goutnik
Modified: 2019-08-15 18:28 UTC (History)
2 users (show)

See Also:


Attachments
patch file (2.23 KB, patch)
2019-08-15 14:53 UTC, Dmitri Goutnik
sascha: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer 2019-08-15 14:53:46 UTC
Created attachment 206581 [details]
patch file

===>  Building for fzf-0.18.0
$GOPATH/go.mod exists but should not
*** Error code 1

- Switch to USES=go:modules, this also fixes the build with go1.13
- Remove custom build/install targets

QA:
  poudriere testport: OK (120a-go1.12.8, 120a-go-devel)
Comment 1 Sascha Holzleiter 2019-08-15 18:23:07 UTC
Comment on attachment 206581 [details]
patch file

Looks good, thanks for the patch!
Comment 2 commit-hook freebsd_committer 2019-08-15 18:28:24 UTC
A commit references this bug:

Author: yuri
Date: Thu Aug 15 18:28:18 UTC 2019
New revision: 509040
URL: https://svnweb.freebsd.org/changeset/ports/509040

Log:
  textproc/fzf: Switch to USES=go:modules, fix build with go1.13

  PR:		239881
  Submitted by:	Dmitri Goutnik <dg@syrec.org>
  Approved by:	sascha@root-login.org (maintainer)

Changes:
  head/textproc/fzf/Makefile
Comment 3 Yuri Victorovich freebsd_committer 2019-08-15 18:28:46 UTC
Committed, thanks!