Created attachment 206603 [details]
armv7 needs the same fix that i386 needs.
Comment on attachment 206603 [details]
Looks OK but...
- Add for armv6 as well as LLD behaves similar if forced via -fuse-ld
- Make sure to document error message in commit log, so the line can be dropped in future if the error disappears or someone fixes it in a different way
Such a fix is covered by portmgr blanket, anyway.
In ffmpeg we have:
It would seem reasonable to have the same in gstreamer-ffmpeg.
But yes, go ahead, commit the fix. It's subject to the build fix blanket, as Jan said.
A commit references this bug:
Date: Wed Sep 4 09:30:25 UTC 2019
New revision: 511072
multimedia/gstreamer-ffmpeg: fix build on armv6, armv7, aarch64
LDFLAGS+=-Wl,-z,notext is needed on those.
Submitted by: riggs (ultimate version)
Approved by: linimon (mentor)
When landing a fix for bustage make sure to document the error for posterity. Someone in future may want to report it upstream, fix in a better way, confirm when no longer necessary, etc.
For one, passing -Wl,-z,notext is usually only required on 32-bit architectures. When it was added to multimedia/ffmpeg for aarch64 I've documented the error, so anyone can review if the approach is correct, not just blindly trust the committer.