Bug 239933 - lang/ruby26: plist issue when RDOC=off
Summary: lang/ruby26: plist issue when RDOC=off
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-18 00:03 UTC by Syouichi TAKAMIYA
Modified: 2019-08-21 22:40 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ruby)


Attachments
PLIST fix (1.14 KB, patch)
2019-08-21 13:13 UTC, Sunpoet Po-Chuan Hsieh
sunpoet: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Syouichi TAKAMIYA 2019-08-18 00:03:05 UTC
When updating ruby from version 2.6.2 to 2.6.3, new file "delete_suffix.rb" has been added in csv library.
But I can't find it in version 2.6.3_3,1 installation of lang/ruby26 ports.
(/usr/local/lib/ruby/2.6/csv/delete_suffix.rb not found)

This problem cause "file not found" errors when executing scripts using csv library.

I think it's incomplete or old pkg-plist problem.
Comment 1 Koichiro Iwao freebsd_committer 2019-08-21 02:48:44 UTC
Ruby 2.6.2 never appeared in the ports tree. When Ruby 2.6 series added the ports tree, it was 2.6.3.  So updating ruby 2.6.2 -> 2.6.3 nerver happens. What do you mean that?
Comment 2 Koichiro Iwao freebsd_committer 2019-08-21 02:51:54 UTC
For the reference: https://svnweb.freebsd.org/ports?view=revision&revision=501068

Ruby 2.6.2 has never appeared in the ports tree.
Comment 3 Koichiro Iwao freebsd_committer 2019-08-21 03:01:55 UTC
Also can you share us the minimum snippet using CSV library to reproduce?
Comment 4 Syouichi TAKAMIYA 2019-08-21 11:28:53 UTC
I'm sorry for sending incomplete bug report.

After further investigation, csv/delete_suffix.rb disappear
when "RDOC" option is off.

How to reproduce :

1. When "make config" command , set "RDOC" option to off
2. install ruby26 port
3. execute this command : ruby -rcsv -e 'print "test"'
or just cd into /usr/local/lib/ruby/2.6/csv/.

I think below is suspicious:

Line 8908 of pkg-plist:

%%RDOC%%%%RUBY_LIBDIR%%/csv/delete_suffix.rb

Note :

ruby 2.6.2 -> 2.6.3 is just information when "delete_suffix.rb" in csv library is added. I'm sorry for ambiguous expression.
Comment 5 Sunpoet Po-Chuan Hsieh freebsd_committer 2019-08-21 13:13:32 UTC
Created attachment 206751 [details]
PLIST fix

- Fix PLIST
- Bump PORTREVISION
Comment 6 Koichiro Iwao freebsd_committer 2019-08-21 14:48:58 UTC
(In reply to Sunpoet Po-Chuan Hsieh from comment #5)
Thanks for the patch. LGTM. Ship it!
Comment 7 commit-hook freebsd_committer 2019-08-21 19:28:05 UTC
A commit references this bug:

Author: sunpoet
Date: Wed Aug 21 19:27:35 UTC 2019
New revision: 509546
URL: https://svnweb.freebsd.org/changeset/ports/509546

Log:
  Fix PLIST

  - Bump PORTREVISION for package change

  PR:		239933
  Submitted by:	Syouichi TAKAMIYA <takazeki@gmail.com>

Changes:
  head/Mk/bsd.ruby.mk
  head/lang/ruby26/pkg-plist
Comment 8 Sunpoet Po-Chuan Hsieh freebsd_committer 2019-08-21 19:30:45 UTC
Committed. Thanks!
Comment 9 Syouichi TAKAMIYA 2019-08-21 22:40:42 UTC
I have confirmed this problem was fixed in my environment. Thank you!