Bug 240036 - net/samba410: allow to disable ZEROCONF
Summary: net/samba410: allow to disable ZEROCONF
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Timur I. Bakeyev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-22 14:35 UTC by Dmitry Marakasov
Modified: 2019-09-11 21:19 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (timur)


Attachments
Patch (766 bytes, patch)
2019-08-22 14:35 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2019-08-22 14:35:58 UTC
Created attachment 206789 [details]
Patch

Turn ZEROCONF options SINGLE into RADIO, allowing to disable both options.
Comment 2 Timur I. Bakeyev freebsd_committer 2019-08-23 21:03:15 UTC
(In reply to Dmitry Marakasov from comment #0)


Hi, Dmitry!

What is the reason behind this patch? As you may noticed the SINGLE option was inroduced in samba410 and for the good reason - vfs_fruit requires one or (with the patch) another ZEROCONF library for proper functioning.

By disabling both libs you'll get crippled vfs_fruit with semi-working, hard to debug functionality.
Comment 3 VVD 2019-08-24 00:15:25 UTC
(In reply to Timur I. Bakeyev from comment #2)
I don't need nor vfs_fruit, neither ZEROCONF at all.
Comment 4 Dries Michiels 2019-08-24 18:19:02 UTC
Would love to have this functionality as well. If things break its on the user.
Comment 5 Dmitry Marakasov freebsd_committer 2019-08-26 16:44:54 UTC
(In reply to Timur I. Bakeyev from comment #2)
I have no idea what vfs_fruit is and don't need it. I use samba with all options turned off and strongly prefer neither extra depends nor having potentially insecure network libraries with unpredictable by design behavior in my system.
Comment 6 Dmitry Marakasov freebsd_committer 2019-09-09 14:11:17 UTC
Ping?
Comment 7 Timur I. Bakeyev freebsd_committer 2019-09-09 19:16:59 UTC
(In reply to Dmitry Marakasov from comment #6)

Pong.

Dmitry, I'm open to the suggestions how to reorganize the port that would make more users happy.

If we'd have normal multi-packaging done from one port it would be an ideal solution. But it was promised to us years ago and we are still where we are...

I was looking in the direction of the FLAVORs, but again, port-mgr declined my port with it.

I'd really hate to introduce (sub)ports like samba410-fileserver, samba410-addc, samba410-adclinet, but if that's the only way...

Here is what I do want to preserve:

vfs_fruit - compatibility layer that emulates MacOSX SMB server and TimeMachine MUST be compiled with ZEROCONF. (as well as Samba has to be linked with cyrus-sasl-gssapi, but I gave up there already..).

So, we may TRY to make vfs_fruit a port OPTION, and if it is SELECTED - enforce ZEROCONF. But I have some difficulties to express that via OPTIONS. If you can help me here - I'll be glad to fulfill that request.
Comment 8 VVD 2019-09-09 21:12:11 UTC
(In reply to Timur I. Bakeyev from comment #7)
> So, we may TRY to make vfs_fruit a port OPTION, and if it is SELECTED - enforce ZEROCONF. But I have some difficulties to express that via OPTIONS. If you can help me here - I'll be glad to fulfill that request.

Something like this:
OPTIONS_DEFINE=                 AD_DC ADS DEBUG DOCS FAM LDAP \
                                QUOTAS SYSLOG UTMP PROFILE VFS_FRUIT
VFS_FRUIT_DESC=                 vfs_fruit support (require AVAHI or MDNSRESPONDER)
VFS_FRUIT_CONFIGURE_ENABLE=         vfs_fruit?????
VFS_FRUIT_VARS=                     SAMBA4_MODULES+=vfs_fruit

.if ${PORT_OPTIONS:MVFS_FRUIT} && !${PORT_OPTIONS:MAVAHI} && !${PORT_OPTIONS:MMDNSRESPONDER}
IGNORE=         VFS_FRUIT require AVAHI or MDNSRESPONDER
.endif
Comment 9 Dmitry Marakasov freebsd_committer 2019-09-11 21:19:05 UTC
(In reply to Timur I. Bakeyev from comment #7)

> Dmitry, I'm open to the suggestions how to reorganize the port that would make more users happy.

There is a patch attached which does exactly this. I don't see how flavors and subports you've mentioned are even related. AVAHI option is still enabled by default, so default port configuration and a package are not affected. All non-default configurations are for users who understand what they are doing.