Bug 240082 - devel/jetbrains-phpstorm: Update to 2019.2.1
Summary: devel/jetbrains-phpstorm: Update to 2019.2.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pedro F. Giffuni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-24 19:58 UTC by Dmitry Wagin
Modified: 2019-08-29 21:02 UTC (History)
1 user (show)

See Also:
pfg: maintainer-feedback+


Attachments
jetbrains-phpstorm.diff (8.17 KB, patch)
2019-08-24 19:58 UTC, Dmitry Wagin
no flags Details | Diff
jetbrains-phpstorm.diff (8.40 KB, patch)
2019-08-24 20:09 UTC, Dmitry Wagin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Wagin 2019-08-24 19:58:06 UTC
Created attachment 206861 [details]
jetbrains-phpstorm.diff

1) Update to 2019.2.1
2) drop dependency on intellij-pt4j port. That port should be removed, it includes an old pt4j version and the FreeBSD native library is already included in the upstream pty4j jar
3) small cleanup
Comment 1 Dmitry Wagin 2019-08-24 20:09:51 UTC
Created attachment 206863 [details]
jetbrains-phpstorm.diff

clean up
Comment 2 Pedro F. Giffuni freebsd_committer freebsd_triage 2019-08-26 02:54:39 UTC
Approved as maintainer. Adding Mentor for commit approval.

As a side note: I did try replacing the batik dependency but the bundled version number doesn't match our packaged version so such operation looks risky.
Comment 3 Pedro F. Giffuni freebsd_committer freebsd_triage 2019-08-26 03:44:11 UTC
Hmm .. I am having trouble with this update: there are Java errors when starting from the console, It is not getting the right background from my previous settings. It may be license issues (I need to update the license as well). We may have to hold off a bit or even skip this version (has happened before).

For now perhaps we should just fix the JAVA_VERSION.
Comment 4 Dmitry Wagin 2019-08-26 12:10:02 UTC
(In reply to Pedro F. Giffuni from comment #3)

about JAVA_VERSION
https://github.com/freebsd/freebsd-ports/commit/b5ebfdc55691931f7fd9f598db0aca2d50db89c3

I have no problem using this release.
Comment 5 Pedro F. Giffuni freebsd_committer freebsd_triage 2019-08-26 16:23:34 UTC
(In reply to Dmitry Wagin from comment #4)

OK, I updated the license, deleted intellij-pty4j and everything works again.
Comment 6 Thierry Thomas freebsd_committer freebsd_triage 2019-08-29 16:54:45 UTC
Approved (as mentor).
Comment 7 commit-hook freebsd_committer freebsd_triage 2019-08-29 21:00:02 UTC
A commit references this bug:

Author: pfg
Date: Thu Aug 29 20:59:22 UTC 2019
New revision: 510186
URL: https://svnweb.freebsd.org/changeset/ports/510186

Log:
  devel/jetbrains-phpstorm: Update to 2019.2.1

  1) Update to 2019.2.1
  2) drop dependency on intellij-pt4j port. That port should be removed, it
  includes an old pt4j version and the FreeBSD native library is already included
  in the upstream pty4j jar
  3) small cleanup

  PR:	240082
  Approved by:	thierry (mentor)

Changes:
  head/devel/jetbrains-phpstorm/Makefile
  head/devel/jetbrains-phpstorm/distinfo
  head/devel/jetbrains-phpstorm/files/pkg-message.in
  head/devel/jetbrains-phpstorm/pkg-plist
Comment 8 Pedro F. Giffuni freebsd_committer freebsd_triage 2019-08-29 21:02:08 UTC
Committed thanks!