Bug 240110 - x11-fm/thunar: use udisks2 to add support for removable storage devices
Summary: x11-fm/thunar: use udisks2 to add support for removable storage devices
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-xfce (Nobody)
URL: https://forum.xfce.org/viewtopic.php?...
Keywords: needs-patch, needs-qa
Depends on: 240138
Blocks:
  Show dependency treegraph
 
Reported: 2019-08-25 21:13 UTC by PauAmma
Modified: 2019-08-27 01:19 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback? (xfce)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description PauAmma freebsd_triage 2019-08-25 21:13:22 UTC
So in the process of researching why thunar-volman wasn't installed with the rest of x11-fm/thunar, I found https://forum.xfce.org/viewtopic.php?id=7283, but I'm not sure that rationale is still applicable now that FreeBSD has devel/libgudev and devel/libudev-devd. Is it time to add these as dependencies and make thunar-volman part of thunar again?
Comment 1 Guido Falsi freebsd_committer 2019-08-25 21:32:46 UTC
(In reply to PauAmma from comment #0)

Hi,

I need to investigate this. At present I'm busy with the XFCE 4.14 update.

Altough hunar (and xfdekstop) are able to notice, mount and unmount removable devices (though hal and polkit) so it does not look like a very urgent addition.

Anyway if possible it would be useful.

Could you provide patches?

I will be able to look into it after the 4.14 update is committed.
Comment 2 PauAmma freebsd_triage 2019-08-25 22:00:09 UTC
(In reply to Guido Falsi from comment #1)
Wow, thanks for the quick answer!

I can certainly try supplying a first-draft patch, but I think I'll wait until the XFCE 4.14 update is there in order to not waste effort and not get in your way, unless it works better for you the other way round. Let me know?
Comment 3 Guido Falsi freebsd_committer 2019-08-25 22:09:18 UTC
(In reply to PauAmma from comment #2)

For the fast answer, I happened to be at the PC when I saw the email to the mailing list.


Also the code I'm working on to update the ports tree is being reviewed and available here:

https://reviews.freebsd.org/D21278

So if you want to start drafting your patch on that you can.
Comment 4 Olivier Duchateau 2019-08-26 15:58:15 UTC
No, it is not so simple. We can't merge thunar-volman into thunar. And if we have gudev, libudev-devd is not equal to Linux's libudev.

In FreeBSD we have not the sys filesystem (thunar-volman uses this type of block devices). Moreover I'm not sure we define same properties of block devices as Linux.

For example thunar-volman checks these properties (based on the struct udev_device through GUdevClient)

- ID_USB_DRIVER
- ID_MODEL
- ID_CLASS

and so on.

thunar-volman could work on FreeBSD, but it requires depth changes. I think it is more easy (and beneficial to other desktops like GNOME, and MATE) to port the udisk2 service, and add support in Thunar and Xfdesktop.