Bug 240125 - net-p2p/transmission-gtk: Fix .desktop file when NLS disabled
Summary: net-p2p/transmission-gtk: Fix .desktop file when NLS disabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alexandre C. Guimarães
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-26 13:53 UTC by Tijl Coosemans
Modified: 2019-08-27 16:39 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rigoletto)
koobs: merge-quarterly?


Attachments
patch (2.56 KB, patch)
2019-08-26 13:53 UTC, Tijl Coosemans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer 2019-08-26 13:53:19 UTC
Created attachment 206924 [details]
patch

When the NLS option is disabled the installed transmission-gtk.desktop file contains fields that start with and underscore, like _Name instead of Name.  When the NLS option is enabled these are replaced by translations.  The attached patch adds a simple sed command that removes the underscores when NLS is disabled.
Comment 1 commit-hook freebsd_committer 2019-08-27 16:38:23 UTC
A commit references this bug:

Author: rigoletto
Date: Tue Aug 27 16:37:28 UTC 2019
New revision: 510018
URL: https://svnweb.freebsd.org/changeset/ports/510018

Log:
  net-p2p/transmission-gtk: Fix .desktop file when NLS disabled.

  When the NLS option is disabled the installed transmission-gtk.desktop file
  contains fields that start with and underscore, like _Name instead of Name.
  When the NLS option is enabled these are replaced by translations.  The attached
  patch adds a simple sed command that removes the underscores when NLS is
  disabled.

  PR:		240125
  Submitted by:	tijl
  Approved by:	tcberner (mentor)

Changes:
  head/net-p2p/transmission-cli/files/patch-gtk_CMakeLists.txt
  head/net-p2p/transmission-gtk/Makefile
Comment 2 Alexandre C. Guimarães freebsd_committer 2019-08-27 16:39:56 UTC
Thank you. :)