Bug 240140 - mail/milter-greylist: add DRAC and SpamAssassin OPTIONS
Summary: mail/milter-greylist: add DRAC and SpamAssassin OPTIONS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
Keywords: needs-qa
Depends on:
Reported: 2019-08-27 05:18 UTC by Helge Oldach
Modified: 2021-02-10 20:06 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (m.tsatsenko)

Patch (969 bytes, patch)
2019-08-27 05:18 UTC, Helge Oldach
koobs: maintainer-approval? (m.tsatsenko)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Helge Oldach 2019-08-27 05:18:40 UTC
Created attachment 206946 [details]

The summary says it essentially. Attached trivial patch adds options for DRAC and SpamAssassin to milter-greylist. Neither of these currently can be enabled through the options menu, but is supported by milter-greylist and covered in the ports documentation.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-27 07:04:44 UTC
Should these be added to OPTIONS_DEFAULT (for package users)
Comment 2 Helge Oldach 2019-08-27 07:47:05 UTC
(In reply to Kubilay Kocak from comment #1)
I think it's better to not make these default, in order to maintain backward compatibility. Also, the appropriate configuration snippets are not included in the sample greylist.conf.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-27 08:25:17 UTC
(In reply to Helge Oldach from comment #2)

I agree with keeping backward compatibility, but not necessarily on it's own, and that it should be weighed up with value of packages to users out of the box in the general case, which I believe should always be priority #1. 

Obviously weighing those two considerations against dependency proliferation is important too.

It would be lovely to have our cake and eat it too (subpackages will help with this in the future).

With packages these days, the defacto is 'lean toward more by default out of the box, unless its ridiculous/exceptional'
Comment 4 Helge Oldach 2019-08-27 09:34:56 UTC
(In reply to Kubilay Kocak from comment #3)
Got your point, though we might consider that SpamAssassin will pull in many more packages (in my case 115!) while the DRAC option is standalone. At the end of the day I don't have a strong opinion on this.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-27 10:14:24 UTC
(In reply to Helge Oldach from comment #4)

Yeh SpamAssassin is fairly heavy. Alternative to defaulting the option ON, isa  slave port to mail/milter-greylist for a spamassasin-enabled version (mail/milter-greylist-spamassasin)

No strong opinion here either, just wanted to make sure the questions/considerations were raised
Comment 6 m.tsatsenko 2019-09-01 09:52:33 UTC
The patch seems OK for me.
Speaking of enabling spamasassin by default I am with the submitter and I personally prefer to keep it disabled by default as it has toons of dependencies.
Although having a slave port seems totally reasonable
Comment 7 commit-hook freebsd_committer 2021-01-13 19:32:47 UTC
A commit references this bug:

Author: dinoex
Date: Wed Jan 13 19:32:16 UTC 2021
New revision: 561502
URL: https://svnweb.freebsd.org/changeset/ports/561502

  - update to 4.6.3
  - fix crash with option GEOIP
  PR:		240140
  Submitted by:	m.tsatsenko@gmail.com
  MFH:		2021Q1

Comment 8 Helge Oldach 2021-02-10 20:06:29 UTC
Fixed by patch commited through bug #239334