Bug 240143 - x11/waybar: fails to build with libfmt 6.0.0
Summary: x11/waybar: fails to build with libfmt 6.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL: https://github.com/Alexays/Waybar/iss...
Keywords:
Depends on:
Blocks: 240141
  Show dependency tree / graph
 
Reported: 2019-08-27 07:04 UTC by Tobias Kortkamp
Modified: 2019-08-29 10:39 UTC (History)
0 users

See Also:
jbeich: maintainer-feedback+

Attachments
v0 (1.55 KB, patch)
2019-08-27 14:21 UTC, Jan Beich 		no flags Details | Diff
v1 (1.55 KB, patch)
2019-08-29 02:25 UTC, Jan Beich 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-08-27 07:04:31 UTC 
In file included from ../src/factory.cpp:1:
In file included from ../include/factory.hpp:4:
../include/modules/clock.hpp:5:10: fatal error: 'fmt/time.h' file not found
#include "fmt/time.h"
         ^~~~~~~~~~~~
1 error generated.
ninja: build stopped: subcommand failed.
*** Error code 1
Comment 1 Jan Beich freebsd_committer freebsd_triage 2019-08-27 14:21:52 UTC 
Created attachment 206954 [details]
v0

Does this help? The fix is not compatible with 5.3.0:

../src/modules/clock.cpp:16:25: error: no member named 'localtime' in namespace 'fmt'
  auto localtime = fmt::localtime(std::chrono::system_clock::to_time_t(now));
                   ~~~~~^
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-08-27 15:00:51 UTC 
(In reply to Jan Beich from comment #1)
Yes, this seems to be fine. Thanks.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2019-08-29 02:25:08 UTC 
Created attachment 206994 [details]
v1

- Restore compatibility with libfmt 5.3.0 (requested upstream)

Now it should be possible to land (bug) dependencies *before* actual libfmt update.
Comment 4 Jan Beich freebsd_committer freebsd_triage 2019-08-29 10:39:23 UTC 
Obsolete after ports r510152.