Bug 240169 - sysutils/minikube: Switch to USES=go:modules, fix build with go1.13
Summary: sysutils/minikube: Switch to USES=go:modules, fix build with go1.13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Danilo Egea Gondolfo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-28 13:41 UTC by Dmitri Goutnik
Modified: 2019-09-02 23:24 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (danilo)


Attachments
patch file (865 bytes, patch)
2019-08-28 13:41 UTC, Dmitri Goutnik
dmgk: maintainer-approval? (danilo)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer 2019-08-28 13:41:06 UTC
Created attachment 206976 [details]
patch file

===>  Building for minikube-1.2.0
go: github.com/Azure/go-ansiterm@v0.0.0-20170929234023-d6e3b3328b78: Get https://proxy.golang.org/github.com/%21azure/go-ansiterm/@v/v0.0.0-20170929234023-d6e3b3328b78.mod: dial tcp: lookup proxy.
golang.org on 209.222.18.218:53: write udp 127.0.0.1:64984->209.222.18.218:53: write: permission d
enied
*** Error code 1

- Switch to USES=go:modules, this also fixes the build with upcoming go1.13
- Remove GO_PKGNAME, not needed with modules

QA:
  poudriere testport: OK (120a-go1.12.9, 120a-go-devel)
Comment 1 commit-hook freebsd_committer 2019-09-02 23:23:32 UTC
A commit references this bug:

Author: danilo
Date: Mon Sep  2 23:22:58 UTC 2019
New revision: 510899
URL: https://svnweb.freebsd.org/changeset/ports/510899

Log:
  - Switch to USES=go:modules, fix build with go1.13 [1]
  while here
  - Update to 1.3.1

  PR:		240169
  Submitted by:	Dmitri Goutnik <dg@syrec.org> [1]

Changes:
  head/sysutils/minikube/Makefile
  head/sysutils/minikube/distinfo
  head/sysutils/minikube/files/patch-pkg_minikube_constants_constants__freebsd.go
Comment 2 Danilo Egea Gondolfo freebsd_committer 2019-09-02 23:24:20 UTC
Committed, thanks!