Bug 240238 - net/asterisk-g72x: Uses non-existent CONFIGURE_ARGS flavors helpers
Summary: net/asterisk-g72x: Uses non-existent CONFIGURE_ARGS flavors helpers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2019-08-31 19:53 UTC by Tobias Kortkamp
Modified: 2019-09-02 07:37 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+
madpilot: merge-quarterly+

Attachments
asterisk-g72x.diff (985 bytes, patch)
2019-08-31 19:53 UTC, Tobias Kortkamp 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-08-31 19:53:14 UTC 
Created attachment 207050 [details]
asterisk-g72x.diff

There is no CONFIGURE_ARGS flavors helper, so there is either something wrong
in the port that needs to be fixed or all the *_CONFIGURE_ARGS should be removed.
At the moment they are just nops.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2019-09-01 08:18:39 UTC 
Good catch.

I'm not sure how this is possible but this one actually compiles and also work even without this option with all asterisk versions.

Only chance is that the differences between the versions we have in the ports tree are similar enough.

Anyway I'd rather patch it so that the correct flags are passed since you noticed this problem. I'll commit a fix after some tests.

Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-09-02 07:09:50 UTC 
A commit references this bug:

Author: madpilot
Date: Mon Sep  2 07:08:55 UTC 2019
New revision: 510764
URL: https://svnweb.freebsd.org/changeset/ports/510764

Log:
  - Correctly pass CONFIGURE_ARGS depending on flavor
  - Fix default FLAVOR definition

  PR:		240238
  Submitted by:	tobik
  MFH:		2019Q3

Changes:
  head/net/asterisk-g72x/Makefile
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2019-09-02 07:11:34 UTC 
Fix committed. I actually made a few mistakes in this port.

Waiting for MFH to close the bug.
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2019-09-02 07:37:15 UTC 
Merged. Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-09-02 07:37:54 UTC 
A commit references this bug:

Author: madpilot
Date: Mon Sep  2 07:36:55 UTC 2019
New revision: 510768
URL: https://svnweb.freebsd.org/changeset/ports/510768

Log:
  MFH: r510764

  - Correctly pass CONFIGURE_ARGS depending on flavor
  - Fix default FLAVOR definition

  PR:		240238
  Submitted by:	tobik

  Approved by:	ports-secteam (joneum)

Changes:
_U  branches/2019Q3/
  branches/2019Q3/net/asterisk-g72x/Makefile