Bug 240250 - Add STANDARDS Section to gre(4) manual page
Summary: Add STANDARDS Section to gre(4) manual page
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-doc (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-09-01 14:59 UTC by Gordon Bergling
Modified: 2020-07-07 18:38 UTC (History)
2 users (show)

See Also:

Attachments
patch for standards section in gre(4) (1.98 KB, patch)
2019-09-01 14:59 UTC, Gordon Bergling 		no flags Details | Diff
New Patch addressing comments by hrs (1.68 KB, application/mbox)
2019-09-26 10:30 UTC, Gordon Bergling 		no flags Details
New Patch with addresses comments (1.68 KB, application/mbox)
2019-09-26 10:57 UTC, Gordon Bergling 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gordon Bergling freebsd_committer freebsd_triage 2019-09-01 14:59:49 UTC 
Created attachment 207066 [details]
patch for standards section in gre(4)

Add STANDARDS section to the gre(4) manual page.

Obtained from OpenBSD
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2019-09-22 13:14:49 UTC 
Take.
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2019-09-22 13:52:09 UTC 
https://reviews.freebsd.org/D21752
Comment 3 Gordon Bergling freebsd_committer freebsd_triage 2019-09-26 10:30:56 UTC 
Created attachment 207840 [details]
New Patch addressing comments by hrs

The following patch addressing hrs comments from phabricator. The not supporting RFC are removed. The WCCP standards could be listed here as a generell reference point.
Comment 4 Gordon Bergling freebsd_committer freebsd_triage 2019-09-26 10:57:20 UTC 
Created attachment 207841 [details]
New Patch with addresses comments

The following patch addressing hrs comments from phabricator. The not supporting RFC are removed. The WCCP standards could be listed here as a generell reference point.
Comment 5 Gordon Bergling freebsd_committer freebsd_triage 2019-11-23 17:35:24 UTC 
Has someone read my comment on review.freebsd.org regarding the updated patch for the gre(4) manual page?
Comment 6 Mateusz Piotrowski freebsd_committer freebsd_triage 2019-11-23 18:45:52 UTC 
(In reply to Gordon Bergling from comment #5)

I've not seen the comment. 

I have this PR on my todo list, I'll commit it soon.
Comment 7 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-03-31 08:49:53 UTC 
Return to pool
Comment 8 commit-hook freebsd_committer freebsd_triage 2020-06-29 10:31:21 UTC 
A commit references this bug:

Author: gbe
Date: Mon Jun 29 10:30:43 UTC 2020
New revision: 362779
URL: https://svnweb.freebsd.org/changeset/base/362779

Log:
  gre(4): Add a STANDARDS section

  Expand the mentioned RFC in the SEE ALSO section
  and reference RFC1701 and RFC1702.

  PR:	240250
  Reviewed by:	bcr (mentor)
  Approved by:	bcr (mentor)
  Obtained from:	OpenBSD
  MFC after:	7 days
  Differential Revision:	https://reviews.freebsd.org/D25504

Changes:
  head/share/man/man4/gre.4
Comment 9 commit-hook freebsd_committer freebsd_triage 2020-07-07 18:37:45 UTC 
A commit references this bug:

Author: gbe
Date: Tue Jul  7 18:37:07 UTC 2020
New revision: 362996
URL: https://svnweb.freebsd.org/changeset/base/362996

Log:
  MFC r362779: gre(4): Add a STANDARDS section

  Expand the mentioned RFC in the SEE ALSO section
  and reference RFC1701 and RFC1702.

  PR:	240250
  Reviewed by:	bcr (mentor)
  Approved by:	bcr (mentor)
  Obtained from:	OpenBSD
  Differential Revision:	https://reviews.freebsd.org/D25504

Changes:
_U  stable/12/
  stable/12/share/man/man4/gre.4