Bug 240270 - multimedia/dvdauthor: Fails to build if GraphicsMagick is installed (and IMAGEMAGICK=OFF)
Summary: multimedia/dvdauthor: Fails to build if GraphicsMagick is installed (and IMAG...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
Keywords: needs-qa
Depends on:
Reported: 2019-09-02 08:45 UTC by Ting-Wei Lan
Modified: 2020-10-02 18:38 UTC (History)
3 users (show)

See Also:
koobs: merge-quarterly?

svn-diff-dvdauthor (2.02 KB, patch)
2019-09-02 09:56 UTC, Walter Schwarzenfeld
no flags Details | Diff
Full build log (23.78 KB, text/plain)
2019-09-04 17:42 UTC, Ting-Wei Lan
no flags Details
config.log (103.75 KB, text/plain)
2019-09-04 17:42 UTC, Ting-Wei Lan
no flags Details
svn diff from /usr/ports/multimedia/dvdauthor (2.44 KB, patch)
2020-10-01 23:00 UTC, Chad Jacob Milios
no flags Details | Diff
svn diff from /usr/ports/multimedia/dvdauthor (2.33 KB, patch)
2020-10-02 18:38 UTC, Chad Jacob Milios
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2019-09-02 08:45:23 UTC
It fails with the following messages:

gmake[3]: Entering directory '/wrkdirs/usr/ports/multimedia/dvdauthor/work/dvdauthor/src'
/bin/sh ../libtool  --tag=CC   --mode=link cc -Wall -O2 -pipe  -DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing   -fstack-protector-strong  -o dvdauthor dvdauthor.o dvdcompile.o d
vdvml.o dvdvmy.o dvdifo.o dvdvob.o dvdpgc.o dvdcli.o readxml.o conffile.o compat.o  -L/usr/local/lib -lxml2 -lz -L/usr/lib -llzma -L/usr/lib -lm -L/usr/local/lib
libtool: link: cc -Wall -O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -fstack-protector-strong -o dvdauthor dvdauthor.o dvdcompile.o dvdvml.o dvdvmy.o dvdifo.o dvdvob
.o dvdpgc.o dvdcli.o readxml.o conffile.o compat.o  -L/usr/local/lib -lxml2 -lz -L/usr/lib -llzma -lm
cc -DHAVE_CONFIG_H -I.  -DSYSCONFDIR="\"/usr/local/etc\"" -I/usr/local/include/libxml2 -I/usr/include -I/usr/local/include/libpng16  -I/usr/local/include/freetype2 -I/usr/local/include/fribidi -I/usr/local/include  -I/us
r/local/include -I/usr/local/include/freetype2  -DLIBICONV_PLUG -isystem /usr/local/include -Wall -O2 -pipe  -DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -MT subgen-image.o -
MD -MP -MF .deps/subgen-image.Tpo -c -o subgen-image.o subgen-image.c
subgen-image.c:33:10: fatal error: 'magick/api.h' file not found
#include <magick/api.h>
1 error generated.
gmake[3]: *** [Makefile:597: subgen-image.o] Error 1
gmake[3]: Leaving directory '/wrkdirs/usr/ports/multimedia/dvdauthor/work/dvdauthor/src'
gmake[2]: *** [Makefile:412: all] Error 2
gmake[2]: Leaving directory '/wrkdirs/usr/ports/multimedia/dvdauthor/work/dvdauthor/src'
gmake[1]: *** [Makefile:414: all-recursive] Error 1
gmake[1]: Leaving directory '/wrkdirs/usr/ports/multimedia/dvdauthor/work/dvdauthor'
*** Error code 1

It can be worked around by enabling IMAGEMAGICK option. I didn't spend time figuring out the proper way to fix it.
Comment 1 Walter Schwarzenfeld freebsd_triage 2019-09-02 09:56:06 UTC
Created attachment 207094 [details]

Include magick/api.h from GraphicsMagick results in a linker error.
So I remove defined(HAVE_GMAGICK) from subgen-image.c.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-03 02:45:01 UTC
@Ting-Wei Could you please include additional information:

- Full build log (as an attachment)
- WRKSRC/config.log output (as an attachment)
- pkg version -v output (as an attachment)
- System information (uname -a)
- /etc/make.conf contents (as an attachment)

Note: The port currently contains the following block to (apparently) disable imagemagick in the case the option is disabled:

    @${REINPLACE_CMD} 's|usemagick=1|usemagick=0|g' \

Presumably this is insufficient. It was added in ports r305215 (committer CC'd)
Comment 3 Ting-Wei Lan 2019-09-04 17:42:03 UTC
Created attachment 207189 [details]
Full build log
Comment 4 Ting-Wei Lan 2019-09-04 17:42:36 UTC
Created attachment 207190 [details]
Comment 5 Ting-Wei Lan 2019-09-04 17:46:55 UTC
(In reply to Kubilay Kocak from comment #2)
> - pkg version -v output (as an attachment)
All packages are up-to-date. I tested it with ports r510311.

> - System information (uname -a)
FreeBSD 12_0-amd64-default 12.0-RELEASE-p10 FreeBSD 12.0-RELEASE-p10 amd64

> - /etc/make.conf contents (as an attachment)
There was no custom settings in /etc/make.conf. It was generated by poudriere.
Comment 6 Chad Jacob Milios 2020-10-01 19:54:07 UTC
i ran into this same error today with IMAGEMAGICK both on or off. (i have both GraphicsMagick-1.3.35,1 and ImageMagick7- installed.)

Applying the patch resulted in a completed build with IMAGEMAGICK off, but not on. The same error still occurs when i try to build with IMAGEMAGICK support turned on.
Comment 7 Chad Jacob Milios 2020-10-01 23:00:55 UTC
Created attachment 218457 [details]
svn diff from /usr/ports/multimedia/dvdauthor

includes patch from earlier submission. should now support building and linking against ImageMagick6. see bug #250033 if you like keeping ImageMagick7 installed also like i did
Comment 8 Chad Jacob Milios 2020-10-02 18:38:43 UTC
Created attachment 218473 [details]
svn diff from /usr/ports/multimedia/dvdauthor