Bug 240296 - net/phpldapadmin: Fix search for php73
Summary: net/phpldapadmin: Fix search for php73
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Torsten Zuehlsdorff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-03 09:08 UTC by Krzysztof
Modified: 2019-09-03 21:11 UTC (History)
1 user (show)

See Also:
koobs: merge-quarterly?


Attachments
phpldapadmin extra patch for php73 (2.56 KB, patch)
2019-09-03 09:08 UTC, Krzysztof
ports: maintainer-approval+
Details | Diff
Poudriere log (29.38 KB, text/plain)
2019-09-03 09:10 UTC, Krzysztof
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof 2019-09-03 09:08:29 UTC
Created attachment 207133 [details]
phpldapadmin extra patch for php73

Hi,

I've found that PLA is not working correctly with php73 - sarch button.

I've made an extra patch (only applied for php73 support), so attached patch is correcting this issue.

I've tested this patch with portlint and poudrieere. There is no errors.
Comment 1 Krzysztof 2019-09-03 09:10:28 UTC
Created attachment 207134 [details]
Poudriere log

I'm adding log from poudriere
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-03 09:15:07 UTC
Thank you for the report and patch Krzysztof

Please use the maintainer-approval attachment flag (set to +) to signify maintainer approval on patches for ports you maintain

Attachment -> Details -> maintainer-approval [+], or alternatively, set the flag during attachment upload
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-03 09:15:25 UTC
(In reply to Kubilay Kocak from comment #2)

Ignore, I see you've already done that. Thank you
Comment 4 commit-hook freebsd_committer 2019-09-03 21:09:50 UTC
A commit references this bug:

Author: tz
Date: Tue Sep  3 21:09:28 UTC 2019
New revision: 511040
URL: https://svnweb.freebsd.org/changeset/ports/511040

Log:
  net/phpldapadmin: fix search button in PHP 7.3

  Add a patch to fix the search button which is only broken with PHP 7.3.

  PR:		240296
  Submitted by:	Krzysztof (maintainer)

Changes:
  head/net/phpldapadmin/Makefile
  head/net/phpldapadmin/files/extra-patch-lib__PageRender.php
Comment 5 Torsten Zuehlsdorff freebsd_committer 2019-09-03 21:11:24 UTC
Committed. Thank you for your patch! :)