Bug 240307 - security/openvpn-devel: switch to POSIX-compatible regex
Summary: security/openvpn-devel: switch to POSIX-compatible regex
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks: 229925
  Show dependency treegraph
 
Reported: 2019-09-03 17:10 UTC by Kyle Evans
Modified: 2019-09-06 19:20 UTC (History)
2 users (show)

See Also:
mandree: maintainer-feedback+


Attachments
svn(1) diff against the ports tree (1.24 KB, patch)
2019-09-03 17:10 UTC, Kyle Evans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer 2019-09-03 17:10:06 UTC
Created attachment 207151 [details]
svn(1) diff against the ports tree

A test run with bug #229925 reveals one sed expression that uses the GNU-extension "\s". Given that this is the only occurrence and it's a trivial fix, update it to be POSIX-compatible.

I've created bug #240306 for security/openvpn{,-mbedtls} and noted that some assistance with upstreaming would be appreciated -- it's a trivial patch and shouldn't be objectionable.
Comment 1 Kyle Evans freebsd_committer 2019-09-06 18:23:20 UTC
Take, since maintainer is not a committer (as per https://wiki.freebsd.org/KubilayKocak/ThePerfectPortsIssue)
Comment 2 ecrist 2019-09-06 18:24:50 UTC
But what if I *want* to be a committer?
Comment 3 Matthias Andree freebsd_committer 2019-09-06 18:58:16 UTC
Take after IRC with kevans@#bsdports and ecrist@#openvpn-devel.
Comment 4 Matthias Andree freebsd_committer 2019-09-06 19:18:47 UTC
I have received maintainer feedback on IRC and by e-mail.
Comment 5 commit-hook freebsd_committer 2019-09-06 19:20:02 UTC
A commit references this bug:

Author: mandree
Date: Fri Sep  6 19:19:01 UTC 2019
New revision: 511355
URL: https://svnweb.freebsd.org/changeset/ports/511355

Log:
  Patch sed(1) regexp in self-test script from GNU to POSIX syntax.

  PR:		240307
  Submitted by:	kevans@
  Approved by:	ecrist@secure-computing.net (maintainer)

Changes:
  head/security/openvpn-devel/files/patch-tests_t__lpback.sh