Created attachment 207152 [details] svn(1) diff against the ports tree Makefile.in has a number of escapes (all following @ in the sed expression) that serve no legitimate purpose as far as I can tell. Escaping ordinary characters is considered undefined behavior by POSIX, and bug #229925 aims to serve out errors for escaping of most ordinary characters to reduce friction when some of these sequences are given special meaning. Things seem to come out OK looking with this patch applied, but I have no way to functionally test.
^Triage: Reporter is committer, assign accordingly
Comment on attachment 207152 [details] svn(1) diff against the ports tree Approved by: portmgr (blanket: unmaintained port) Pending QA
Comment on attachment 207152 [details] svn(1) diff against the ports tree If the changes pass QA (portlint, poudriere): Approved by: koobs (ports)
Created attachment 207177 [details] svn(1) diff against the ports tree Fix the diff... we must literally replace @libexecdir@ and @python@ in these files, so the variables we sed in Makefile.in (the configure patch) must be renamed to not conflict.
Makefile.in has a number of escapes (all following @ in the sed expression) that serve no legitimate purpose as far as I can tell. Escaping ordinary characters is considered undefined behavior by POSIX, and bug #229925 aims to serve out errors for escaping of most ordinary characters to reduce friction when some of these sequences are given special meaning. QA: * portlint: OK (minor warnings that should be addressed separately) * testport: OK (poudriere: 13.0-CURRENT and 12.0-RELEASE, amd64) * diffoscope: OK (only minor metadata changes to package)
A commit references this bug: Author: kevans Date: Fri Sep 6 21:20:26 UTC 2019 New revision: 511366 URL: https://svnweb.freebsd.org/changeset/ports/511366 Log: security/fsh: Remove redundant escapes of ordinary characters Makefile.in has a number of escapes (all following @ in the sed expression) that only serve to stop a sed in the configure script from replacing them. Escaping ordinary characters is considered undefined behavior by POSIX, and the patch in bug #229925 aims to serve out errors for escaping of most ordinary characters to reduce friction when some of these sequences are given special meaning. QA: * portlint: OK (minor warnings that should be addressed separately) * testport: OK (poudriere: 13.0-CURRENT and 12.0-RELEASE, amd64) * diffoscope: OK (only minor metadata changes to package) PR: 240308 Approved by: koobs (ports) Changes: head/security/fsh/files/ head/security/fsh/files/patch-Makefile.in head/security/fsh/files/patch-configure