Bug 240382 - net/radsecproxy: Update to 1.8.0, Remove BROKEN (on 12/13)
Summary: net/radsecproxy: Update to 1.8.0, Remove BROKEN (on 12/13)
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-07 00:55 UTC by Jørn Åne de Jong
Modified: 2019-09-14 23:17 UTC (History)
1 user (show)

See Also:
m.tsatsenko: maintainer-feedback+
koobs: merge-quarterly?


Attachments
net/radsecproxy patch 2019090600 (3.91 KB, patch)
2019-09-07 00:55 UTC, Jørn Åne de Jong
no flags Details | Diff
net/radsecproxy patch 2019090700 (4.82 KB, patch)
2019-09-07 14:24 UTC, Jørn Åne de Jong
no flags Details | Diff
net/radsecproxy patch 2019091100 (5.80 KB, patch)
2019-09-11 10:53 UTC, Jørn Åne de Jong
m.tsatsenko: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jørn Åne de Jong 2019-09-07 00:55:50 UTC
Created attachment 207253 [details]
net/radsecproxy patch 2019090600

It seems the net/radsecproxy port has not received any updates for some time.

- The port does currently not compile on FreeBSD 12 or FreeBSD 13.  

- The port still refers to version 1.6.8, which is two years old.  Version 1.8.0 came out two months ago.

- The project moved to Github and the old download location is not available anymore.

I've updated the Makefile to refer to the new download location, and to the newest version.  Version 1.8.0 seems to have a missing include statement but compiles when that's fixed.  I've included a patch in the port for this, and submitted the patch upstream [1].  I've also included a patch that corrects paths in the example config file.

The port seems to run fine, I was able to connect to WiFi in a test setup where radsecproxy 1.8.0 on 12.0-RELEASE received TLS traffic which it forwarded to a local RADIUS server.  I didn't test this port on CURRENT though.

This is my first port work, there are two details I'm not sure about:

1. The radsecproxy example configuraion file states that the file should be placed at /usr/local/etc/radsecproxy/radsecproxy.conf, but the FreeBSD port uses /usr/local/etc/radsecproxy.conf. Should I correct this, provided that this will break setups for those who already installed this port earlier?

2. The project uses autotools, but provides a manually built .tar.gz that comes with a prebuilt configure script and Makefile. This file is not chosen by the standard Github macros in the FreeBSD porting scripts. Is it preferable to use autoreconf or to override the download location?

Please let me know if I can do anything to make this patch better.

[1] https://github.com/radsecproxy/radsecproxy/pull/53
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-07 01:21:19 UTC
Review items:

- Use USES=localbase:ldflags instead of CPPFLAGS/LDFLAGS
Comment 2 Jørn Åne de Jong 2019-09-07 14:24:11 UTC
Created attachment 207258 [details]
net/radsecproxy patch 2019090700

Updated patch after feedback

- Set USES localbase:ldflags instead of setting LDFLAGS and CPPFLAGS
- Change from dual GPLv2 BSD3CLAUSE to single BSD3CLAUSE license [1]
- Copyright SWITCH [1]
- Bump TIMESTAMP in distinfo

QA:

portlint: OK (looks fine.)
testport: OK (poudriere: 120Ramd64, 120Ri386, 113Ramd64, 113Ri386)

[1] https://github.com/radsecproxy/radsecproxy/blob/1.8.0/ChangeLog#L40-L42
Comment 3 m.tsatsenko 2019-09-07 21:56:05 UTC
Comment on attachment 207258 [details]
net/radsecproxy patch 2019090700

Seems fine.
Thanks!
Comment 4 Jørn Åne de Jong 2019-09-11 10:53:24 UTC
Created attachment 207378 [details]
net/radsecproxy patch 2019091100

Changes from 20190907:

- Made the port compile with:
  - base (already worked)
  - security/openssl (already worked)
  - security/libressl
  - libressl-devel
- Tested running with all *ssl alternatives on 12.0-RELEASE amd64
- Re-run make makepatch

QA:

portlint: OK (looks fine.)
testport: OK (poudriere: 120Ramd64, 120Ri386, 113Ramd64, 113Ri386, 112Ramd64, 112Ri386)
Comment 5 Jørn Åne de Jong 2019-09-11 11:26:54 UTC
Output from ldd /usr/local/sbin/radsecproxy:

base: /usr/local/sbin/radsecproxy:
	libssl.so.111 => /usr/lib/libssl.so.111 (0x800268000)
	libcrypto.so.111 => /lib/libcrypto.so.111 (0x8002fd000)
	libnettle.so.7 => /usr/local/lib/libnettle.so.7 (0x8005ea000)
	libthr.so.3 => /lib/libthr.so.3 (0x800625000)
	libc.so.7 => /lib/libc.so.7 (0x800650000)

security/openssl: /usr/local/sbin/radsecproxy:
	libssl.so.9 => /usr/local/lib/libssl.so.9 (0x800268000)
	libcrypto.so.9 => /usr/local/lib/libcrypto.so.9 (0x8002e4000)
	libnettle.so.7 => /usr/local/lib/libnettle.so.7 (0x80056b000)
	libthr.so.3 => /lib/libthr.so.3 (0x8005a6000)
	libc.so.7 => /lib/libc.so.7 (0x8005d1000)

security/libressl: /usr/local/sbin/radsecproxy:
	libssl.so.47 => /usr/local/lib/libssl.so.47 (0x800268000)
	libcrypto.so.45 => /usr/local/lib/libcrypto.so.45 (0x8002c4000)
	libnettle.so.7 => /usr/local/lib/libnettle.so.7 (0x8004b3000)
	libthr.so.3 => /lib/libthr.so.3 (0x8004ee000)
	libc.so.7 => /lib/libc.so.7 (0x800519000)

security/libressl-devel: /usr/local/sbin/radsecproxy:
	libssl.so.47 => /usr/local/lib/libssl.so.47 (0x800268000)
	libcrypto.so.45 => /usr/local/lib/libcrypto.so.45 (0x8002c5000)
	libnettle.so.7 => /usr/local/lib/libnettle.so.7 (0x8004b6000)
	libthr.so.3 => /lib/libthr.so.3 (0x8004f1000)
	libc.so.7 => /lib/libc.so.7 (0x80051c000)
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-14 03:28:39 UTC
@Maintainer, could you please review the latest patch and accept (or not) using the maintainer-approval attachment flag please
Comment 7 m.tsatsenko 2019-09-14 23:17:01 UTC
Comment on attachment 207378 [details]
net/radsecproxy patch 2019091100

Approved. Thanks!