Bug 240402 - audio/mumble: Update to 1.3.0
Summary: audio/mumble: Update to 1.3.0
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mark Felder
URL: https://github.com/mumble-voip/mumble...
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2019-09-08 01:38 UTC by VVD
Modified: 2019-09-13 00:43 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (feld)


Attachments
Update to release 1.3.0 (6.71 KB, patch)
2019-09-08 14:41 UTC, VVD
no flags Details | Diff
Update to release 1.3.0 (6.75 KB, patch)
2019-09-13 00:43 UTC, VVD
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description VVD 2019-09-08 01:38:41 UTC
"Mumble 1.3 is finally here!"

I'm trying make patch.
Comment 1 VVD 2019-09-08 14:41:49 UTC
Created attachment 207292 [details]
Update to release 1.3.0

* Update to release 1.3.0 (tested on 12.0 amd64 and i386)
* Added optional PULSEAUDIO support: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238438 (probably tested by the author of the patch)
* Added optional ALSA support (not tested)
* Added optional JACK support (not tested)
* Replaced in USES dependency from "python:2.7" on "python" - default is 3.6 now (tested on 12.0 amd64 and i386)
Comment 2 Chris W. 2019-09-08 22:50:31 UTC
audio/mumble/work/mumble-1.3.0/release/libmumble.so.1.3.0 is missing
stops compiling.

but i can execute audio/mumble/work/mumble-1.3.0/release/mumble

something is wrong.

Jackaudio seems working.
Comment 3 Chris W. 2019-09-08 23:08:41 UTC
(In reply to Chris W. from comment #2)

my bad:

have compiled with "make -j4" and it broke. With "make" it completes compiling.

sorry
Comment 4 Chris W. 2019-09-11 00:17:18 UTC
I have tested the patch and works for me.

I am no Reviewer but it looks fine.
Comment 5 Mark Felder freebsd_committer 2019-09-12 15:17:55 UTC
(In reply to Chris W. from comment #4)

It's not fine. Fails in poudriere because of missing libraries after the build. If you are building out of your ports tree on a live system with a previously installed version of Mumble it will appear to work, but it's not correct.

Something odd is going on with qmake. I'm talking to the Mumble developers and trying to figure out what happened between the older beta and now.
Comment 6 VVD 2019-09-12 21:42:55 UTC
(In reply to Mark Felder from comment #5)
Just tested on 2 hosts - 12.0 amd64 and i386:
pkg delete -yf mumble
portmaster audio/mumble

Build without errors.
Comment 7 Sebastian Schwarz 2019-09-12 21:53:24 UTC
With the current patch I get the following error in Poudriere on FreeBSD:12:amd64:

> Project ERROR: Unable to find the system's Python binary. Some scripts invoked during the Mumble build use Python. You can manually specify it via the MUMBLE_PYTHON environment variable (either 2 or 3).

Adding "QMAKE_ENV+=MUMBLE_PYTHON=${PYTHON_CMD}" to the patched Makefile alleviates that problem.  The result builds and runs here.  I don't seem to be missing any libraries.

Also doesn't the error message say that Python is a build-time only dependency?  Shouldn't it be "USES=python:build" instead of "USES=python"?
Comment 8 VVD 2019-09-12 22:44:16 UTC
(In reply to Sebastian Schwarz from comment #7)
> Adding "QMAKE_ENV+=MUMBLE_PYTHON=${PYTHON_CMD}" to the patched Makefile alleviates that problem.
In what place of the Makefile?

> Also doesn't the error message say that Python is a build-time only dependency?  > Shouldn't it be "USES=python:build" instead of "USES=python"?
May be… Tried it - build and work fine without python for me.
Comment 9 Chris W. 2019-09-12 23:17:16 UTC
(In reply to Sebastian Schwarz from comment #7)

I thought python is used in audio/murmur the server not audio/mumble the client. Or am i wrong?
Comment 10 VVD 2019-09-13 00:43:17 UTC
Created attachment 207448 [details]
Update to release 1.3.0

Ye, it can't find python3 if python2 isn't installed.