Bug 240423 - games/ufoai: Fails to build with mxml 3.1
Summary: games/ufoai: Fails to build with mxml 3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: https://reviews.freebsd.org/P306
Keywords:
Depends on:
Blocks: 240422
  Show dependency treegraph
 
Reported: 2019-09-08 17:16 UTC by Tobias Kortkamp
Modified: 2019-09-22 04:27 UTC (History)
1 user (show)

See Also:
tobik: maintainer-feedback-


Attachments
ufoai.diff (1.03 KB, patch)
2019-09-08 17:30 UTC, Tobias Kortkamp
tobik: maintainer-approval? (m.tsatsenko)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2019-09-08 17:16:59 UTC
src/common/xml.cpp:523:14: error: member access into incomplete type 'mxml_node_t' (aka '_mxml_node_s')
                type = node->value.element.name;
                           ^
/usr/local/include/mxml.h:97:16: note: forward declaration of '_mxml_node_s'
typedef struct _mxml_node_s mxml_node_t;        /**** An XML node. ****/
               ^
9 warnings and 1 error generated.

Full log at https://reviews.freebsd.org/P306
Comment 1 Tobias Kortkamp freebsd_committer 2019-09-08 17:30:58 UTC
Created attachment 207297 [details]
ufoai.diff

- Apply upstream commit [1] to fix build

[1] https://github.com/ufoai/ufoai/commit/163073ab9527cdaa33d77a713b8e46ff462a2b5c
Comment 2 commit-hook freebsd_committer 2019-09-22 04:27:30 UTC
A commit references this bug:

Author: tobik
Date: Sun Sep 22 04:26:40 UTC 2019
New revision: 512550
URL: https://svnweb.freebsd.org/changeset/ports/512550

Log:
  games/ufoai: Prepare for mxml 3.1

  src/common/xml.cpp:523:14: error: member access into incomplete type 'mxml_node_t' (aka '_mxml_node_s')
  type = node->value.element.name;
  ^
  /usr/local/include/mxml.h:97:16: note: forward declaration of '_mxml_node_s'
  typedef struct _mxml_node_s mxml_node_t;        /**** An XML node. ****/
  ^
  9 warnings and 1 error generated.

  PR:		240423
  Approved by:	m.tsatsenko@gmail.com (maintainer timeout, 14 days)

Changes:
  head/games/ufoai/Makefile
  head/games/ufoai/distinfo