Bug 240433 - emulators/virtualbox-ose-additions: fix build with "make -s"
Summary: emulators/virtualbox-ose-additions: fix build with "make -s"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-09 06:46 UTC by Franco Fichtner
Modified: 2019-09-09 11:03 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (vbox)


Attachments
ECHO_CMD replacement (1.91 KB, patch)
2019-09-09 06:46 UTC, Franco Fichtner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Franco Fichtner 2019-09-09 06:46:09 UTC
Created attachment 207313 [details]
ECHO_CMD replacement

${ECHO} is a make(1) builtin which is empty when "-s" is used.  For functional build modifications ${ECHO_CMD} must be used, because the build fails otherwise.
Comment 1 commit-hook freebsd_committer 2019-09-09 11:02:13 UTC
A commit references this bug:

Author: tobik
Date: Mon Sep  9 11:01:14 UTC 2019
New revision: 511620
URL: https://svnweb.freebsd.org/changeset/ports/511620

Log:
  emulators/virtualbox-ose*: Use ECHO_CMD not ECHO per bsd.commands.mk

  - Unbreak `make -s` builds

  PR:		240433, 240426
  Submitted by:	Franco Fichtner <franco@opnsense.org> (based on)

Changes:
  head/emulators/virtualbox-ose/Makefile
  head/emulators/virtualbox-ose-additions/Makefile
  head/emulators/virtualbox-ose-kmod/Makefile