Bug 240445 - ports-mgmt/portlint: PYQT-related false positives
Summary: ports-mgmt/portlint: PYQT-related false positives
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joe Marcus Clarke
Depends on:
Reported: 2019-09-09 13:44 UTC by vladimir.chukharev
Modified: 2020-03-02 22:24 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)

Patch (1.20 KB, patch)
2019-09-09 13:44 UTC, vladimir.chukharev
vladimir.chukharev: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description vladimir.chukharev 2019-09-09 13:44:13 UTC
Created attachment 207325 [details]


portlint gives false positives about PYQT related variables. This can be seen with the following.
$ ( cd /usr/ports/graphics/py-traitsui ; portlint -Ca )
WARN: Makefile: When USES=pyqt:5 is defined, you must also define USE_PYQT=xxxx
0 fatal errors and 1 warning found.

A discussion can found at https://reviews.freebsd.org/D21229 .

I propose a patch adding USE_PYQT to @varlist and checking $makevar if static text analysis does not find the variable. This fixes the bug for me, but you better carefully test the patch, since I do not use Perl myself.

The patch also bumps the port version, sorry if that disturbs...

port test : OK
poudriere : OK
portlint -Ca: OK

Comment 1 Joe Marcus Clarke freebsd_committer 2020-03-02 22:24:03 UTC
Committed to 2.18.11, thanks.