Bug 240450 - x11-toolkits/p5-Alien-wxWidgets: remove extraneous escapes
Summary: x11-toolkits/p5-Alien-wxWidgets: remove extraneous escapes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-perl (Nobody)
URL:
Keywords:
Depends on:
Blocks: 229925
  Show dependency treegraph
 
Reported: 2019-09-09 16:18 UTC by Kyle Evans
Modified: 2020-02-20 19:09 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (perl)


Attachments
svn(1) diff against the ports tree (1.02 KB, patch)
2019-09-09 16:18 UTC, Kyle Evans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer 2019-09-09 16:18:44 UTC
Created attachment 207330 [details]
svn(1) diff against the ports tree

post-patch phase of this port uses sed to replace 'wx-config with '${WX_CONFIG:T}. Previously it escaped the ', but this is not necessary in this context.

Remove the extraneous escape so that it doesn't get passed through to sed(1) as an escape of an ordinary character. This is important as the patch in bug #229925 will make such escapes an error to ease transition into a world where some escaped-ordinaries will be granted a special meaning.

This patch also contains a pkg-plist update to include Config/gtk_3* -- I do not know if this is correct, but it was needed to get through a poudriere testport so I've included it.

QA:
 * portlint: OK (minor warnings that should be addressed separately.)
 * testport: OK (poudriere: 12.0-RELEASE, amd64[*])

[*] Only minimal testing done because the nature of the patch would lead to arch-independent catastrophic meltdown
Comment 1 commit-hook freebsd_committer 2020-02-20 18:58:49 UTC
A commit references this bug:

Author: kevans
Date: Thu Feb 20 18:58:18 UTC 2020
New revision: 526580
URL: https://svnweb.freebsd.org/changeset/ports/526580

Log:
  x11-toolkits/p5-Alien-wxWidgets: remove extraneous escapes

  post-patch phase of this port uses sed to replace 'wx-config with
  '${WX_CONFIG:T}. Previously it escaped the ', but this is not necessary in
  this context.

  Remove the extraneous escape so that it doesn't get passed through to sed(1)
  as an escape of an ordinary character. This is important as the patch in bug
  #229925 will make such escapes an error to ease transition into a world
  where some escaped-ordinaries will be granted a special meaning.

  PR:		240450
  Approved by:	koobs (mentor), bapt (mentor)
  Approved by:	portmgr (maintainer timeout: 4 months)
  MFH:		2020Q1 (future build fix)
  Differential Revision:	https://reviews.freebsd.org/D23702

Changes:
  head/x11-toolkits/p5-Alien-wxWidgets/Makefile
Comment 2 commit-hook freebsd_committer 2020-02-20 19:08:54 UTC
A commit references this bug:

Author: kevans
Date: Thu Feb 20 19:08:31 UTC 2020
New revision: 526585
URL: https://svnweb.freebsd.org/changeset/ports/526585

Log:
  MFH: r526580

  x11-toolkits/p5-Alien-wxWidgets: remove extraneous escapes

  post-patch phase of this port uses sed to replace 'wx-config with
  '${WX_CONFIG:T}. Previously it escaped the ', but this is not necessary in
  this context.

  Remove the extraneous escape so that it doesn't get passed through to sed(1)
  as an escape of an ordinary character. This is important as the patch in bug
  #229925 will make such escapes an error to ease transition into a world
  where some escaped-ordinaries will be granted a special meaning.

  PR:		240450
  Approved by:	koobs (mentor), bapt (mentor)
  Approved by:	portmgr (maintainer timeout: 4 months)
  Differential Revision:	https://reviews.freebsd.org/D23702

  Approved by:	ports-secteam (implicit, future build fix)

Changes:
_U  branches/2020Q1/
  branches/2020Q1/x11-toolkits/p5-Alien-wxWidgets/Makefile