Created attachment 207421 [details] [patch] make highlight dependency explicit at configure time If textproc/source-highlight is installed when you run 'make -C textproc/gtk-doc configure', the configure phase will detect source-highlight first before highlight. This makes gtk-doc implicitly dependent on source-highlight. If source-highlight is later removed, gtk-doc is broken (config.py contains a now invalid reference to source-highlight). This is solved by specifying --with-highlight=highlight for configure. While here, appease portlint a bit by moving USES earlier. I could see that this could merit a PORTREVISION bump, but this change shouldn't change packages that are currently built on the freebsd package servers (a poudriere gtk-doc build jail would not have the source-highlight package installed). QA: - poudriere textport: ok - portlint: ok
Maintainer timeout?
Committed. Thank you.
A commit references this bug: Author: tcberner Date: Sun Aug 2 16:04:59 UTC 2020 New revision: 543973 URL: https://svnweb.freebsd.org/changeset/ports/543973 Log: textproc/gtk-doc: make configure dependency on highlight explicit If textproc/source-highlight is installed when you run 'make -C textproc/gtk-doc configure', the configure phase will detect source-highlight first before highlight. This makes gtk-doc implicitly dependent on source-highlight. If source-highlight is later removed, gtk-doc is broken (config.py contains a now invalid reference to source-highlight). This is solved by specifying --with-highlight=highlight for configure. PR: 240536 Submitted by: John Hein <jcfyecrayz@liamekaens.com> Changes: head/textproc/gtk-doc/Makefile