Bug 240536 - textproc/gtk-doc: make configure dependency on highlight explicit
Summary: textproc/gtk-doc: make configure dependency on highlight explicit
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-12 14:06 UTC by John Hein
Modified: 2019-09-12 14:07 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
[patch] make highlight dependency explicit at configure time (703 bytes, patch)
2019-09-12 14:06 UTC, John Hein
jcfyecrayz: maintainer-approval? (gnome)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2019-09-12 14:06:19 UTC
Created attachment 207421 [details]
[patch] make highlight dependency explicit at configure time

If textproc/source-highlight is installed when you run 'make -C textproc/gtk-doc configure', the configure phase will detect source-highlight first before highlight.  This makes gtk-doc implicitly dependent on source-highlight.  If source-highlight is later removed, gtk-doc is broken (config.py contains a now invalid reference to source-highlight).

This is solved by specifying --with-highlight=highlight for configure.

While here, appease portlint a bit by moving USES earlier.

I could see that this could merit a PORTREVISION bump, but this change shouldn't change packages that are currently built on the freebsd package servers (a poudriere gtk-doc build jail would not have the source-highlight package installed).

QA:
 - poudriere textport: ok
 - portlint: ok