Bug 240568 - graphics/argyllcms: update to 2.1.1
Summary: graphics/argyllcms: update to 2.1.1
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koop Mast
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-13 18:35 UTC by Walter Schwarzenfeld
Modified: 2020-04-11 11:33 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (kwm)


Attachments
svn-diff-argyllcms (2.11 KB, patch)
2019-09-13 18:35 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-argyllcms_v2 (3.07 KB, patch)
2019-09-13 19:59 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-argyllcms_v3 (2.88 KB, patch)
2019-09-13 20:16 UTC, Walter Schwarzenfeld
no flags Details | Diff
Do not extract zlib and other bundled libraries (408 bytes, patch)
2020-03-31 04:05 UTC, Mikhail Teterin
no flags Details | Diff
argyll.patch - 2.1.2 (5.70 KB, patch)
2020-04-11 11:33 UTC, Greg V
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Walter Schwarzenfeld freebsd_triage 2019-09-13 18:35:53 UTC
Created attachment 207471 [details]
svn-diff-argyllcms

Update argyllcms to 2.1.1.
Switch to gcc (clang does not build the files in the spectro directory).

Found no ChangeLog. The Readme files in the source tells it is mostly a bugfix for icc.
Comment 1 Walter Schwarzenfeld freebsd_triage 2019-09-13 18:36:28 UTC
Also tested build with colord, builds fine.
Comment 2 Walter Schwarzenfeld freebsd_triage 2019-09-13 19:59:19 UTC
Created attachment 207475 [details]
svn-diff-argyllcms_v2

Little change cause of portlint.
Comment 3 Walter Schwarzenfeld freebsd_triage 2019-09-13 20:16:52 UTC
Created attachment 207476 [details]
svn-diff-argyllcms_v3

Was an error in.
Comment 4 Mikhail Teterin freebsd_committer 2020-03-31 04:05:47 UTC
Created attachment 212881 [details]
Do not extract zlib and other bundled libraries

Thanks for the submission, Walter. Would you care to update it to 2.1.2, released in January?

Independently, I have this little patch, which prevents the bundled sources for zlib, png, tiff, and jpeg from even being extracted.

This not only saves space at build-time -- the current version (1.9.2) actually compiles the bundled zlib, even if it does not use it! It may well be the case with the 2.1.x versions too...

I wish, yajl and mxml could be similarly excluded, but Argyll has made changes to them, which aren't in their respected upstreams :-(
Comment 5 Greg V 2020-04-11 11:33:51 UTC
Created attachment 213279 [details]
argyll.patch - 2.1.2

Here's 2.1.2 (with the extract patch from above), gcc was not required for me (llvm10 worked fine). Had to add an extra -L flag for LOCALBASE.