Bug 240630 - misc/openvdb: fix build on GCC architectures
Summary: misc/openvdb: fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-17 08:07 UTC by Piotr Kubaj
Modified: 2019-10-12 15:46 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
patch (1.29 KB, patch)
2019-09-17 08:07 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (yuri)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-09-17 08:07:22 UTC
Created attachment 207551 [details]
patch

Compiling on GCC architectures fails:
/wrkdirs/usr/ports/misc/openvdb/work/openvdb-6.1.0/openvdb/points/AttributeSet.cc: In member function 'openvdb::v6_1::points::AttributeSet::Descriptor::Ptr openvdb::v6_1::points::AttributeSet::Descriptor::duplicateDrop(const std::vector<long unsigned int>&) const':
/wrkdirs/usr/ports/misc/openvdb/work/openvdb-6.1.0/openvdb/points/AttributeSet.cc:875:59: error: 'CHAR_BIT' was not declared in this scope
  875 |             const size_t GROUP_BITS = sizeof(GroupType) * CHAR_BIT;
      |                                                           ^~~~~~~~
/wrkdirs/usr/ports/misc/openvdb/work/openvdb-6.1.0/openvdb/points/AttributeSet.cc:35:1: note: 'CHAR_BIT' is defined in header '<climits>'; did you forget to '#include <climits>'?
   34 | #include "AttributeGroup.h"
  +++ |+#include <climits>
   35 | 

While here, add USES=xorg for TOOLS option.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-09-17 17:26:25 UTC
Mentor approval (pending maintainer review): built on ppcports.
Comment 2 commit-hook freebsd_committer 2019-10-12 15:46:23 UTC
A commit references this bug:

Author: pkubaj
Date: Sat Oct 12 15:46:08 UTC 2019
New revision: 514338
URL: https://svnweb.freebsd.org/changeset/ports/514338

Log:
  misc/openvdb: fix build on GCC architectures

  Compiling on GCC architectures fails:
  /wrkdirs/usr/ports/misc/openvdb/work/openvdb-6.1.0/openvdb/points/AttributeSet.cc: In member function 'openvdb::v6_1::points::AttributeSet::Descriptor::Ptr openvdb::v6_1::points::AttributeSet::Descriptor::duplicateDrop(const std::vector<long unsigned int>&) const':
  /wrkdirs/usr/ports/misc/openvdb/work/openvdb-6.1.0/openvdb/points/AttributeSet.cc:875:59: error: 'CHAR_BIT' was not declared in this scope
    875 |             const size_t GROUP_BITS = sizeof(GroupType) * CHAR_BIT;
        |                                                           ^~~~~~~~
  /wrkdirs/usr/ports/misc/openvdb/work/openvdb-6.1.0/openvdb/points/AttributeSet.cc:35:1: note: 'CHAR_BIT' is defined in header '<climits>'; did you forget to '#include <climits>'?
     34 | #include "AttributeGroup.h"
    +++ |+#include <climits>
     35 |

  While here, add USES=xorg for TOOLS option.

  PR:             240630
  Approved by:    linimon (mentor), yuri (maintainer timeout)

Changes:
  head/misc/openvdb/Makefile
  head/misc/openvdb/files/patch-openvdb_points_AttributeSet.cc