Bug 240649 - audio/murmur: Fix broken murmur.ini defaults
Summary: audio/murmur: Fix broken murmur.ini defaults
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Mark Felder
Keywords: needs-qa
Depends on:
Reported: 2019-09-17 18:58 UTC by Jacob Wahlgren
Modified: 2019-09-18 11:46 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (feld)
koobs: merge-quarterly?

Fixes issue with ini values (875 bytes, patch)
2019-09-17 18:58 UTC, Jacob Wahlgren
no flags Details | Diff
Refactoring (2.22 KB, patch)
2019-09-17 18:59 UTC, Jacob Wahlgren
no flags Details | Diff
Removes redundant host= (593 bytes, patch)
2019-09-17 19:00 UTC, Jacob Wahlgren
no flags Details | Diff
Combined patch (2.23 KB, patch)
2019-09-18 11:46 UTC, Jacob Wahlgren
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jacob Wahlgren 2019-09-17 18:58:36 UTC
Created attachment 207579 [details]
Fixes issue with ini values

The sed snippets to set reasonable defaults for pidfile, logfile, and host are incorrectly expecting comments to start with "#" instead of ";". I suspect this is caused by a change upstream, but I haven't verified this. The issue is fixed by the first patch.

The second patch contains a few changes to make the port more in line with recommendations in the Porter's Handbook. The required directories are not created by the rc script, instead they are handled by the Makefile and pkg-plist. The changes to murmur.ini are moved to the post-patch stage which seems more appropriate.

Finally, the third patch simply removes the patching of host in murmur.ini. As the comment in the file states, the equivalent of host= is already default.
Comment 1 Jacob Wahlgren 2019-09-17 18:59:36 UTC
Created attachment 207580 [details]
Comment 2 Jacob Wahlgren 2019-09-17 19:00:11 UTC
Created attachment 207581 [details]
Removes redundant host=
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-18 06:38:15 UTC
Thank you for the report and patches Jacob. Could you combine the three patches into a single unified diff please
Comment 4 Jacob Wahlgren 2019-09-18 11:46:05 UTC
Created attachment 207602 [details]
Combined patch