Bug 240675 - deskutils/py-khal: Broken DOCS option
Summary: deskutils/py-khal: Broken DOCS option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexandre C. Guimarães
URL: https://github.com/pimutils/khal/issu...
Keywords: needs-patch, needs-qa
Depends on:
Reported: 2019-09-19 05:25 UTC by Tobias Kortkamp
Modified: 2019-09-23 17:58 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rigoletto)


Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2019-09-19 05:25:53 UTC
Please fix or remove the DOCS option.  At the moment the DOCS option
is a nop and just adds frivolous run dependencies for no reason AFAICT.

build-DOCS-on does nothing and probably post-build-DOCS-on was
meant.  Even when I correct the target name it still does not build
with what is there at the moment (there is no ${WRKSRC}/docs directory
for starters).  DOCS_RUN_DEPENDS also looks not entirely correct
and maybe they should be build dependencies instead.
Comment 1 Alexandre C. Guimarães freebsd_committer 2019-09-19 14:56:23 UTC
Yeah, the docs are a bit tricky to build. Ever running them manually return a error:

> ModuleNotFoundError: No module named 'khal'

I will see with upstream what is going on.

Comment 2 commit-hook freebsd_committer 2019-09-19 18:03:33 UTC
A commit references this bug:

Author: rigoletto
Date: Thu Sep 19 18:03:04 UTC 2019
New revision: 512363
URL: https://svnweb.freebsd.org/changeset/ports/512363

  deskutils/py-khal: temporarily remove broken DOCS option.

  - the issue will be worked with upstream and the option
    will be re-added when solved.

  PR:		240675
  Reported by:	tobik
  Approved by:	tcberner (mentor)

Comment 3 Alexandre C. Guimarães freebsd_committer 2019-09-19 18:04:56 UTC
I will leave this open until the build issue be addressed.

Thank you.
Comment 4 Alexandre C. Guimarães freebsd_committer 2019-09-23 17:56:03 UTC
The documentation can just be built after 'deskutils/py-khal' be installed, then I would need to create a separated port just for documentation (overkill) or build it after post-install (ugly).

I will leave the port without documentation at least until upstream change the way to build the documentation, and if they change.

Thank you.
Comment 5 Tobias Kortkamp freebsd_committer 2019-09-23 17:58:01 UTC
That sounds sensible. Thank you.