lib.libarchive.functional_test.test_write_filter_zstd starts failing
after r352482 (or r352483):
/usr/src/contrib/libarchive/libarchive/test/test_write_filter_zstd.c:145: Assertion failed: used2 < used1
Description: compression-level=6 wrote 746 bytes, default wrote 744 bytes
A commit references this bug:
Date: Thu Sep 19 13:23:25 UTC 2019
New revision: 352515
Temporarily add test_write_filter_zstd BROKEN_TESTS as it always fails in CI
There is no trivial way to mark single libarchive test skip currently so just
add it to BROKEN_TESTS for now.
Sponsored by: The FreeBSD Foundation
What is weird is yes I can reproduce this bug but only under bhyve, not on regular amd64 machines.
I am adding mm@ to see if he has more insight
I can't reproduce this either natively or on CHERI RISC-V. Maybe we should try removing it from BROKEN_TESTS?
(In reply to Alex Richardson from comment #3)
I haven't checked this for a while, maybe it was fixed silently. Please check it again in bhyve and feel free to enable it.
I think we need a "try broken" CI job to monitor if the skipped/disabled tests get fixed.
(In reply to Li-Wen Hsu from comment #4)
> I think we need a "try broken" CI job to monitor if the skipped/disabled tests
> get fixed.
Ideally the failing tests would just be XFAIL and not fail the whole test / generate email, but absent that having a regular job that tries the broken/excluded tests indeed sounds like a good idea.
We could check the test case name in functional_test.sh?